Attachment 107494 Details for Bug 25499 – Bug 25499: Fix fund code column when closing a budget

[patch] Bug 25499: Fix fund code column when closing a budget

Bug-25499-Fix-fund-code-column-when-closing-a-budg.patch (text/plain), 1.98 KB, created by Joonas Kylmälä on 2020-07-29 12:53:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2020-07-29 12:53:12 UTC

Size: 1.98 KB

patch

obsolete

>From 7ad686eec6045b28fa3977644b87a4b664f93ce7 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sat, 23 May 2020 01:12:22 +0200
>Subject: [PATCH] Bug 25499: Fix fund code column when closing a budget
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>When closing a budget the fund code column in the table is
>always empty. This is due to a TT variable not being correct.
>
>To test:
>- Create a budget and fund
>- Order anything, leave basket open or not, but don't receive
>- Duplicate your existing budget
>- Close the first budget in order to move the pending orders
>- Verify the fund code is not showing in the table
>- Apply patch and reload the patch
>- Verify fund codes are now showing correctly
>
>Bonus: Changes the column heading Fund id to Fund ID.
>
>Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@helsinki.fi>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
>index 3af08680ce..d270976218 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
>@@ -312,7 +312,7 @@
>     <table id="budgeth">
>       <thead>
>         <tr>
>-            <th>Fund id</th>
>+            <th>Fund ID</th>
>             <th>Fund code</th>
>             <th>Fund name</th>
>             <th>Unreceived orders</th>
>@@ -322,7 +322,7 @@
>         [% FOREACH budget IN budgets_to_move %]
>           <tr>
>             <td>[% budget.budget_id | html %]</td>
>-            <td>[% budget.budget_code_indent | html %]</td>
>+            <td>[% budget.budget_code | html %]</td>
>             <td>[% budget.budget_name | html %]</td>
>             <td>[% budget.unreceived_orders.size | html %]</td>
>           </tr>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25499: 105294 | 106636 | 107494