Attachment 107520 Details for Bug 26083 – Bug 26083: Item editor defaults to lost

[patch] Bug 26083: Item editor defaults to lost

Bug-26083-Item-editor-defaults-to-lost.patch (text/plain), 1.86 KB, created by Kyle M Hall (khall) on 2020-07-29 17:06:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-07-29 17:06:21 UTC

Size: 1.86 KB

patch

obsolete

>From e100561bdb45c780c4fd3d5bb6d779f300666ce8 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 29 Jul 2020 13:03:57 -0400
>Subject: [PATCH] Bug 26083: Item editor defaults to lost
>
>When editing an item via additem.pl, koha defaults to the first
>available lost status, rather than defaulting to not-lost.
>
>Test Plan:
>1) Ensure you do not have a value ClaimReturnedLostValue
>2) Edit an existing item that is not lost
>3) Note the lost value is set even though it is not lost
>4) Apply this patch
>5) Edit a different item that is not lost
>6) Note the lost value is not set!
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>index 19ce9aa9f4..051695788c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>@@ -166,7 +166,7 @@
>                         [% IF aval == mv.default %]
>                         <option value="[%- aval | html -%]" selected="selected">[%- mv.labels.$aval | html -%]</option>
>                         [% ELSE %]
>-                            [% IF ite.IS_LOST_AV && aval == Koha.Preference("ClaimReturnedLostValue") %]
>+                            [% IF ite.IS_LOST_AV && Koha.Preference("ClaimReturnedLostValue") && aval == Koha.Preference("ClaimReturnedLostValue") %]
>                                 <option disabled="disabled" value="[%- aval | html -%]" title="Return claims must be processed from the patron details page">[%- mv.labels.$aval | html -%]</option>
>                             [%  ELSE %]
>                                 <option value="[%- aval | html -%]">[%- mv.labels.$aval | html -%]</option>
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 26083: 107520 | 107521 | 107540