Attachment 107534 Details for Bug 26093 – Bug 26093: Markup error after Bug 24279 creates formatting problem

[patch] Bug 26093: Markup error after Bug 24279 creates formatting problem

Bug-26093-Markup-error-after-Bug-24279-creates-for.patch (text/plain), 2.78 KB, created by Owen Leonard on 2020-07-29 20:12:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-07-29 20:12:55 UTC

Size: 2.78 KB

patch

obsolete

>From bdc7b972b86343ca4bc44032da9a3e0e0ffa2f92 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 29 Jul 2020 20:01:24 +0000
>Subject: [PATCH] Bug 26093: Markup error after Bug 24279 creates formatting
> problem
>
>This patch makes a few minor changes to the markup of the item detail
>page in order for everything to be valid and styled correctly:
>
>- Remove unnecessary and invalid <br clear="both"/>
>- Move heading inside container so that floats clear correctly
>- Change <span> tag back to <div> to enable the correct style.
>
>To test, apply the patch and view the item details page for a title with
>multiple items.
>
> - Each section starting with "Barcode" should be bordered above by a
>   two-pixel gray line
> - The "statuses" section should be styled like the areas above and
>   below, not as an ordered list.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>index 12dc7ea7a2..d67674bc6a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>@@ -48,14 +48,15 @@
>     </ol>
>     </div>
> 
>-    <br clear="all" />
>     [% IF ( ONLY_ONE ) %]
>         <div class="dialog message">You are only viewing one item.  <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% biblionumber | uri %]&amp;bi=[% biblioitemnumber | uri %]#item[% itemnumber | uri %]">View All</a></div>
>     [% END %]
> 
>     [% FOREACH ITEM_DAT IN ITEM_DATA %]
>+        <div class="listgroup">
>         <h3 id="item[% ITEM_DAT.itemnumber | html %]">Barcode [% ITEM_DAT.barcode | html %]  [% IF ( ITEM_DAT.notforloantext ) %][% ITEM_DAT.notforloantext | html %] [% END %]</h3>
>-        <div class="listgroup"><h4>Item information [% IF ( CAN_user_editcatalogue_edit_catalogue ) %][% UNLESS ( ITEM_DAT.nomod ) %]
>+
>+        <h4>Item information [% IF ( CAN_user_editcatalogue_edit_catalogue ) %][% UNLESS ( ITEM_DAT.nomod ) %]
>          [% IF ( CAN_user_editcatalogue_edit_items ) %]
>             <a href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&amp;biblionumber=[% ITEM_DAT.biblionumber | uri %]&amp;itemnumber=[% ITEM_DAT.itemnumber | uri %]"><i class="fa fa-pencil"></i> Edit item</a>
>          [% END %]
>@@ -79,7 +80,7 @@
>                 [% IF ( ITEM_DAT.withdrawn ) %]Withdrawn[% END %]
>             )[% END %]</h4>
> 
>-            <span class="rows">
>+            <div class="rows">
>             <ol class="bibliodetails">
>             <li><span class="label">Current location:</span> [% Branches.GetName( ITEM_DAT.holdingbranch ) | html %]&nbsp;</li>
>             <li><span class="label">Checkout status:</span>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26093: 107534 | 107575 | 107578 | 107610