Attachment 107546 Details for Bug 22087 – Bug 22087: Prevent variable names colision

[patch] Bug 22087: Prevent variable names colision

Bug-22087-Prevent-variable-names-colision.patch (text/plain), 2.63 KB, created by Katrin Fischer on 2020-07-29 22:12:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-07-29 22:12:24 UTC

Size: 2.63 KB

patch

obsolete

>From 561982478e86072088faf89745aac8dd71eaff3f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 7 Apr 2020 12:01:05 +0200
>Subject: [PATCH] Bug 22087: Prevent variable names colision
>
>We should not use PROCESS:
>http://www.template-toolkit.org/docs/manual/Directives.html
>
>" The PROCESS directive is slightly faster than INCLUDE because it
>avoids the need to localise (i.e. copy) the variable stash before
>processing the template. "
>
>The 'patron' variable is reused by patron-title.inc
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/modules/members/tables/members_results.tt     | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>index 36ac273022..7c6f6a0294 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>@@ -18,7 +18,7 @@
>                 "dt_cardnumber":
>                     "[% data.cardnumber | html | $To %]",
>                 "dt_name":
>-                    "<a href=\"/cgi-bin/koha/members/moremember.pl?borrowernumber=[% data.borrowernumber | html %]\" class=\"patron_preview\" data-borrowernumber=\"[% data.borrowernumber | html %]\" style='white-space:nowrap'>[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = data.firstname surname = data.surname othernames = data.othernames invert_name = 1 | $To %]</a><br /><div class='address'><ul>[%~ PROCESS 'display-address-style' patron=data no_line_break=1 | $To ~%]</ul></div>[% IF data.email %]<br/>Email: <a href='mailto:[% data.email | html | $To %]'>[% data.email | html | $To %]</a>[% END %]",
>+                    "<a href=\"/cgi-bin/koha/members/moremember.pl?borrowernumber=[% data.borrowernumber | html %]\" class=\"patron_preview\" data-borrowernumber=\"[% data.borrowernumber | html %]\" style='white-space:nowrap'>[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = data.firstname surname = data.surname othernames = data.othernames invert_name = 1 | $To %]</a><br /><div class='address'><ul>[%~ INCLUDE 'display-address-style' patron=data no_line_break=1 | $To ~%]</ul></div>[% IF data.email %]<br/>Email: <a href='mailto:[% data.email | html | $To %]'>[% data.email | html | $To %]</a>[% END %]",
>     "dt_dateofbirth":
>         "[% INCLUDE 'patron-age.inc' patron = data %]",
>                 "dt_category":
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22087: 102043 | 102064 | 102448 | 102449 | 102450 | 102451 | 102466 | 102482 | 102483 | 102484 | 102485 | 102486 | 102492 | 102505 | 102506 | 102507 | 107420 | 107421 | 107422 | 107423 | 107424 | 107425 | 107427 | 107428 | 107543 | 107544 | 107545 | 107546 | 107547 | 107548 | 107549