Bugzilla – Attachment 107575 Details for
Bug 26093
Markup error after Bug 24279 creates formatting problem
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26093: Markup error after Bug 24279 creates formatting problem
Bug-26093-Markup-error-after-Bug-24279-creates-for.patch (text/plain), 3.34 KB, created by
Owen Leonard
on 2020-07-30 11:38:27 UTC
(
hide
)
Description:
Bug 26093: Markup error after Bug 24279 creates formatting problem
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-07-30 11:38:27 UTC
Size:
3.34 KB
patch
obsolete
>From ea812691f90b6fa644559826de7e15a9cea69f57 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 29 Jul 2020 20:01:24 +0000 >Subject: [PATCH] Bug 26093: Markup error after Bug 24279 creates formatting > problem > >This patch makes a few minor changes to the markup of the item detail >page in order for everything to be valid and styled correctly: > >- Remove unnecessary and invalid <br clear="both"/> >- Move heading inside container so that floats clear correctly >- Change <span> tag back to <div> to enable the correct style. > >To test, apply the patch and view the item details page for a title with >multiple items. > > - Each section starting with "Barcode" should be bordered above by a > two-pixel gray line > - The "statuses" section should be styled like the areas above and > below, not as an ordered list. >--- > .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index 12dc7ea7a2..16fb580bb1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -29,6 +29,7 @@ > <h2>[% title | html %]</h2> > [% IF ( subtitle ) %]<h4>[% FOREACH subtitl IN subtitle %] [% subtitl | html %][% END %]</h4>[% END %] > [% IF ( author ) %]<h4>by [% author | html %]</h4>[% END %] >+ <div class="listgroup"> > <div class="rows"> > <ol class="bibliodetails"> > <li><span class="label">Biblionumber:</span> [% biblionumber | html %] </li> >@@ -47,15 +48,18 @@ > <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% biblionumber | uri %]&showallitems=1">Show all items</a>[% END %]</li> > </ol> > </div> >+ </div> > >- <br clear="all" /> > [% IF ( ONLY_ONE ) %] >+ <hr /> > <div class="dialog message">You are only viewing one item. <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% biblionumber | uri %]&bi=[% biblioitemnumber | uri %]#item[% itemnumber | uri %]">View All</a></div> > [% END %] > > [% FOREACH ITEM_DAT IN ITEM_DATA %] >+ <div class="listgroup"> > <h3 id="item[% ITEM_DAT.itemnumber | html %]">Barcode [% ITEM_DAT.barcode | html %] [% IF ( ITEM_DAT.notforloantext ) %][% ITEM_DAT.notforloantext | html %] [% END %]</h3> >- <div class="listgroup"><h4>Item information [% IF ( CAN_user_editcatalogue_edit_catalogue ) %][% UNLESS ( ITEM_DAT.nomod ) %] >+ >+ <h4>Item information [% IF ( CAN_user_editcatalogue_edit_catalogue ) %][% UNLESS ( ITEM_DAT.nomod ) %] > [% IF ( CAN_user_editcatalogue_edit_items ) %] > <a href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=[% ITEM_DAT.biblionumber | uri %]&itemnumber=[% ITEM_DAT.itemnumber | uri %]"><i class="fa fa-pencil"></i> Edit item</a> > [% END %] >@@ -79,7 +83,7 @@ > [% IF ( ITEM_DAT.withdrawn ) %]Withdrawn[% END %] > )[% END %]</h4> > >- <span class="rows"> >+ <div class="rows"> > <ol class="bibliodetails"> > <li><span class="label">Current location:</span> [% Branches.GetName( ITEM_DAT.holdingbranch ) | html %] </li> > <li><span class="label">Checkout status:</span> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26093
:
107534
|
107575
|
107578
|
107610