Attachment 107636 Details for Bug 26085 – Bug 26085: Add the copy, print and export DataTables buttons to lost items report

[patch] Bug 26085: Add the copy, print and export DataTables buttons to lost items report

Bug-26085-Add-the-copy-print-and-export-DataTables.patch (text/plain), 2.35 KB, created by ByWater Sandboxes on 2020-07-31 11:03:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2020-07-31 11:03:14 UTC

Size: 2.35 KB

patch

obsolete

>From e975bf955fbe9dbccb11f5ab25cd55f7a671d736 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 29 Jul 2020 12:58:22 +0000
>Subject: [PATCH] Bug 26085: Add the copy, print and export DataTables buttons
> to lost items report
>
>This patch removes the in-page DataTables DOM configuration option so
>that the default option is used. This will allow all the standard
>controls to appear, including copy/print/export.
>
>Since the default DataTables information includes the number of results
>in the table, the template markup showing this information is removed.
>
>To test, apply the patch and go to Reports.
>
>- Run the "Items lost" report using parameters which will return
>  multiple results.
>- On the results page confirm that the standard controls are present:
>  Result count, search form, columns filter, export buttons.
>- Confirm that the "Activate filters" feature works, and that selecting
>  results activates the option to download a CSV using a CSV export
>  profile.
>
>  Note that the "Activate filters" feature doesn't play well with hidden
>  columns. However this issue predates the patch.
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt | 9 ---------
> 1 file changed, 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
>index ad09c264c2..10d1141cc8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
>@@ -28,14 +28,6 @@
> 
> [% IF ( get_items ) %]
> 
>-<div class="results">
>-    [% IF items.count%]
>-        [% items.count | html %] lost items found
>-    [% ELSE %]
>-        No lost items found
>-    [% END %]
>-</div>
>-
>     [% IF items.count %]
>         [% IF csv_profiles.count %]
>             <div class="lostitems-table_table_controls">
>@@ -196,7 +188,6 @@
>         $(document).ready(function() {
>             var columns_settings = [% TablesSettings.GetColumns( 'reports', 'lostitems', 'lostitems-table', 'json' ) | $raw %];
>             var lostitems_table = KohaTable("lostitems-table", {
>-                "dom": 'B<"clearfix">t',
>                 "aaSorting": [],
>                 "aoColumnDefs": [
>                     { "bSortable": false, "bSearchable": false, 'aTargets': [ 'NoSort' ] },
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26085: 107497 | 107636 | 107652