Bugzilla – Attachment 107692 Details for
Bug 21946
Group circulation by item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21946: (follow-up) Add optgroup label in circ rules
Bug-21946-follow-up-Add-optgroup-label-in-circ-rul.patch (text/plain), 3.01 KB, created by
Jonathan Druart
on 2020-08-03 10:32:52 UTC
(
hide
)
Description:
Bug 21946: (follow-up) Add optgroup label in circ rules
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-08-03 10:32:52 UTC
Size:
3.01 KB
patch
obsolete
>From 49fe9bf2601830c9afe3b9e313dda2e2991015b9 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 28 Jul 2020 13:17:54 +0000 >Subject: [PATCH] Bug 21946: (follow-up) Add optgroup label in circ rules > >This patch adds a label to the optgroup showing child itemtypes in the >circulation and fine rules interface. > >The parent itemtype description is the optgroup label, and then the >parent itemtype is repeated as an <option> with the additional label >"All" >--- > .../prog/en/modules/admin/smart-rules.tt | 22 ++++++++++--------- > 1 file changed, 12 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index a36daf5f4a..b34d02e2fa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -342,18 +342,20 @@ > <td> > <select name="itemtype" id="matrixitemtype" style="width:13em;"> > <option value="*">All</option> >- [% FOREACH itemtypeloo IN itemtypeloop %] >- [% NEXT IF itemtypeloo.parent_type %] >- <option value="[% itemtypeloo.itemtype | html %]">[% itemtypeloo.translated_description | html %]</option> >- [% SET children = itemtypeloo.children_with_localization %] >- [% IF children %] >- <optgroup> >- [% FOREACH child IN children %] >- <option value="[% child.itemtype | html %]">[% child.translated_description | html %]</option> >+ [% FOREACH itemtypeloo IN itemtypeloop %] >+ [% NEXT IF itemtypeloo.parent_type %] >+ [% SET children = itemtypeloo.children_with_localization %] >+ [% IF children %] >+ <optgroup label="[% itemtypeloo.translated_description | html %]"> >+ <option value="[% itemtypeloo.itemtype | html %]">[% itemtypeloo.translated_description | html %] (All)</option> >+ [% FOREACH child IN children %] >+ <option value="[% child.itemtype | html %]">[% child.translated_description | html %]</option> >+ [% END %] >+ </optgroup> >+ [% ELSE %] >+ <option value="[% itemtypeloo.itemtype | html %]">[% itemtypeloo.translated_description | html %]</option> > [% END %] >- </optgroup> > [% END %] >- [% END %] > </select> > </td> > <td class="actions"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21946
:
87713
|
87714
|
87715
|
87716
|
87717
|
87718
|
87719
|
88392
|
88574
|
88575
|
88576
|
88577
|
88578
|
88579
|
88580
|
88581
|
88926
|
88927
|
88928
|
88929
|
88930
|
88931
|
88932
|
88933
|
88934
|
89167
|
89168
|
89169
|
89170
|
89171
|
89172
|
89173
|
89174
|
89175
|
89176
|
93075
|
93076
|
93077
|
93078
|
93079
|
93080
|
93081
|
93082
|
93083
|
93084
|
93086
|
93087
|
93088
|
93089
|
93090
|
93091
|
93092
|
93093
|
93094
|
93095
|
93096
|
93097
|
93098
|
93099
|
93100
|
93101
|
93102
|
93103
|
93104
|
93105
|
96977
|
96978
|
96979
|
96980
|
96981
|
96982
|
96983
|
96984
|
96985
|
96986
|
96987
|
99419
|
99420
|
99421
|
99422
|
99423
|
99424
|
107035
|
107036
|
107037
|
107038
|
107039
|
107040
|
107041
|
107278
|
107279
|
107280
|
107281
|
107282
|
107283
|
107284
|
107467
|
107489
|
107686
|
107687
|
107688
|
107689
|
107690
|
107691
| 107692 |
107693
|
107694
|
107701
|
107733