Bugzilla – Attachment 107730 Details for
Bug 24201
Attach desk to intranet session
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24201: (QA follow-up) Fix desks select box selected attribute
Bug-24201-QA-follow-up-Fix-desks-select-box-select.patch (text/plain), 2.13 KB, created by
Martin Renvoize (ashimema)
on 2020-08-04 10:30:35 UTC
(
hide
)
Description:
Bug 24201: (QA follow-up) Fix desks select box selected attribute
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-08-04 10:30:35 UTC
Size:
2.13 KB
patch
obsolete
>From 9eb4b1e963db6195cefb90d0b319e771ff7ab87c Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Mon, 3 Aug 2020 07:29:15 +0000 >Subject: [PATCH] Bug 24201: (QA follow-up) Fix desks select box selected > attribute > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 4 ++++ > koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >index 2d734cd42d..35386127db 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >@@ -12,7 +12,11 @@ > <option id="nodesk" value="">---</option> > [% FOREACH d IN desks %] > [% IF d.branchcode == branch %] >+ [% IF selected == d.desk_id %] >+ <option class="[% d.branchcode | html %]" value="[% d.desk_id | html %]" selected="selected">[% d.desk_name | html %]</option> >+ [% ELSE %] > <option class="[% d.branchcode | html %]" value="[% d.desk_id | html %]" >[% d.desk_name | html %]</option> >+ [% END %] > [% ELSE %] > <option class="[% d.branchcode | html %]" value="[% d.desk_id | html %]" disabled hidden>[% d.desk_name | html %]</option> > [% END%] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt >index 7ae971915e..8d115f8661 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt >@@ -79,7 +79,7 @@ Updated:<ul> > <ol> > <li><label for="desk">Choose Desk:</label> > <select name="desk_id" id="desk_id"> >- [% PROCESS options_for_desks desks => Desks.all( selected => desk_id ) %] >+ [% PROCESS options_for_desks desks => Desks.all(), selected => desk_id %] > </select></li> > </ol> > </fieldset> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24201
:
96158
|
96164
|
96165
|
96166
|
101452
|
101564
|
101684
|
101697
|
101704
|
101705
|
101848
|
101865
|
101866
|
101877
|
101878
|
101879
|
101880
|
101881
|
101882
|
101883
|
103839
|
103840
|
105795
|
105869
|
105873
|
105874
|
105875
|
106576
|
107089
|
107090
|
107091
|
107092
|
107093
|
107094
|
107095
|
107096
|
107097
|
107667
|
107668
|
107669
|
107670
|
107671
|
107672
|
107673
|
107674
|
107675
|
107676
|
107677
|
107678
|
107679
|
107680
|
107728
|
107729
| 107730 |
107731
|
107732
|
107750
|
107751
|
107752
|
107815
|
107816
|
107817
|
107818
|
107951
|
107952
|
107967
|
107968
|
107980
|
107981