Attachment 107748 Details for Bug 26133 – Bug 26133: Remove GetMarc* calls in detail.pl

[patch] Bug 26133: Remove GetMarc* calls in detail.pl

Bug-26133-Remove-GetMarc-calls-in-detailpl.patch (text/plain), 2.65 KB, created by Jonathan Druart on 2020-08-04 11:58:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-08-04 11:58:41 UTC

Size: 2.65 KB

patch

obsolete

>From 8d7b87db9fb36a67aa03766762dcf5b5647f0cd5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 4 Aug 2020 13:54:28 +0200
>Subject: [PATCH] Bug 26133: Remove GetMarc* calls in detail.pl
>
>There are several calls in catalogue/detail.pl that can be removed:
>GetMarcISBN, GetMarcAuthors, GetMarcSubjects, GetMarcSeries, GetMarcUrls and GetMarcHosts
>They pass a variable to the template that is never used.
>
>Test plan:
>Confirm that this TT variable is never used.
>---
> catalogue/detail.pl | 12 ------------
> opac/opac-detail.pl |  2 --
> 2 files changed, 14 deletions(-)
>
>diff --git a/catalogue/detail.pl b/catalogue/detail.pl
>index d01de155a6..4a2aa3afa7 100755
>--- a/catalogue/detail.pl
>+++ b/catalogue/detail.pl
>@@ -176,12 +176,6 @@ $template->param(
> );
> 
> my $marcnotesarray   = GetMarcNotes( $record, $marcflavour );
>-my $marcisbnsarray   = GetMarcISBN( $record, $marcflavour );
>-my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour );
>-my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
>-my $marcseriesarray  = GetMarcSeries($record,$marcflavour);
>-my $marcurlsarray    = GetMarcUrls    ($record,$marcflavour);
>-my $marchostsarray   = GetMarcHosts($record,$marcflavour);
> 
> my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search->unblessed } };
> 
>@@ -418,12 +412,6 @@ if (scalar(@itemloop) == 0 || scalar(@otheritemloop) == 0) {
> $template->param( norequests => $norequests );
> $template->param(
>     MARCNOTES   => $marcnotesarray,
>-    MARCSUBJCTS => $marcsubjctsarray,
>-    MARCAUTHORS => $marcauthorsarray,
>-    MARCSERIES  => $marcseriesarray,
>-    MARCURLS => $marcurlsarray,
>-    MARCISBNS => $marcisbnsarray,
>-    MARCHOSTS => $marchostsarray,
>     itemdata_ccode      => $itemfields{ccode},
>     itemdata_enumchron  => $itemfields{enumchron},
>     itemdata_uri        => $itemfields{uri},
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index 94a935f0c8..f4bdf3dd70 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -778,7 +778,6 @@ if (!C4::Context->preference("OPACXSLTDetailsDisplay") ) {
>     my $marcsubjctsarray = GetMarcSubjects($record,$marcflavour);
>     my $marcseriesarray  = GetMarcSeries  ($record,$marcflavour);
>     my $marcurlsarray    = GetMarcUrls    ($record,$marcflavour);
>-    my $marchostsarray   = GetMarcHosts($record,$marcflavour);
> 
>     $template->param(
>         MARCSUBJCTS => $marcsubjctsarray,
>@@ -786,7 +785,6 @@ if (!C4::Context->preference("OPACXSLTDetailsDisplay") ) {
>         MARCSERIES  => $marcseriesarray,
>         MARCURLS    => $marcurlsarray,
>         MARCISBNS   => $marcisbnsarray,
>-        MARCHOSTS   => $marchostsarray,
>     );
> }
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26133: 107748 | 107749 | 107826 | 107827