Attachment 107752 Details for Bug 24201 – Bug 24201: (QA follow-up) Correct call to set_userenv

[patch] Bug 24201: (QA follow-up) Correct call to set_userenv

Bug-24201-QA-follow-up-Correct-call-to-setuserenv.patch (text/plain), 1.59 KB, created by Martin Renvoize (ashimema) on 2020-08-04 12:30:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-08-04 12:30:37 UTC

Size: 1.59 KB

patch

obsolete

>From e62fb94a70bf935547827a38789fbdcc3e7eb358 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 4 Aug 2020 12:49:54 +0100
>Subject: [PATCH] Bug 24201: (QA follow-up) Correct call to set_userenv
>
>One call to set_userenv had been implimented incorrectly with the
>parameters out of order.
>---
> C4/Auth.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index c5396781e7..0dfc5ee664 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -1167,7 +1167,7 @@ sub checkauth {
>                     $session->param('surname'),      $session->param('branch'),
>                     $session->param('branchname'),   $session->param('flags'),
>                     $session->param('emailaddress'), $session->param('shibboleth'),
>-                    $session->param('desk_id'), $session->param('desk_name')
>+                    $session->param('desk_id'),      $session->param('desk_name')
>                 );
> 
>             }
>@@ -1444,8 +1444,8 @@ sub check_api_auth {
>                 $session->param('cardnumber'),   $session->param('firstname'),
>                 $session->param('surname'),      $session->param('branch'),
>                 $session->param('branchname'),   $session->param('flags'),
>-                $session->param('emailaddress'), $session->param('desk_id'),
>-                $session->param('desk_name')
>+                $session->param('emailaddress'), $session->param('shibboleth'),
>+                $session->param('desk_id'),      $session->param('desk_name')
>             );
> 
>             my $ip       = $session->param('ip');
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24201: 96158 | 96164 | 96165 | 96166 | 101452 | 101564 | 101684 | 101697 | 101704 | 101705 | 101848 | 101865 | 101866 | 101877 | 101878 | 101879 | 101880 | 101881 | 101882 | 101883 | 103839 | 103840 | 105795 | 105869 | 105873 | 105874 | 105875 | 106576 | 107089 | 107090 | 107091 | 107092 | 107093 | 107094 | 107095 | 107096 | 107097 | 107667 | 107668 | 107669 | 107670 | 107671 | 107672 | 107673 | 107674 | 107675 | 107676 | 107677 | 107678 | 107679 | 107680 | 107728 | 107729 | 107730 | 107731 | 107732 | 107750 | 107751 | 107752 | 107815 | 107816 | 107817 | 107818 | 107951 | 107952 | 107967 | 107968 | 107980 | 107981