Attachment 107878 Details for Bug 26158 – Bug 26158: Fix Z3950 search button broken for translations

[patch] Bug 26158: Fix Z3950 search button broken for translations

Bug-26158-Fix-Z3950-search-button-broken-for-trans.patch (text/plain), 1.84 KB, created by Owen Leonard on 2020-08-06 12:02:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-08-06 12:02:40 UTC

Size: 1.84 KB

patch

obsolete

>From 33b6c85af0c14eeba9324278eaaace77830762b1 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 6 Aug 2020 13:29:44 +0200
>Subject: [PATCH] Bug 26158: Fix Z3950 search button broken for translations
>
>This is similar to bug 23713
>
>var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %]0[% END %];
>
>become, once translated:
>
>var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %][% END %];
>
>and a JS error appears in the console
> Uncaught SyntaxError: expected expression, got ';' search.pl:636:29
>
>Caused by
>  commit ef4306cc02e2f15aa2466ae65d0b4f9a1fd70ad9
>  Bug 23885: Move staff client search results JavaScript into separate file
>
>Test plan:
>Use the staff interface in a translated language
>Search for a term that won't return any results
>Click the Z3950 button
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index 220d7de5ea..72cd9a00a4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -724,7 +724,11 @@
>         var biblionumber = "[% biblionumber | html %]";
>         var holdfor_cardnumber = "[% holdfor_cardnumber | html %]";
>         var holdforclub = "[% holdforclub | html %]";
>-        var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %]0[% END %];
>+        [% IF SEARCH_RESULTS %]
>+            var SEARCH_RESULTS = 1;
>+        [% ELSE %]
>+            var SEARCH_RESULTS = 0;
>+        [% END %]
>         var new_results_browser = [
>             [%- FOREACH result IN SEARCH_RESULTS -%]
>                 [%- result.biblionumber | html -%],
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26158: 107876 | 107878 | 107898