Attachment 107883 Details for Bug 25905 – Bug 25905: Tidy up warns

[patch] Bug 25905: Tidy up warns

Bug-25905-Tidy-up-warns.patch (text/plain), 2.13 KB, created by David Cook on 2020-08-06 12:29:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2020-08-06 12:29:18 UTC

Size: 2.13 KB

patch

obsolete

>From e137254d11c3211a385371c683290f4be0e9b6bd Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 6 Aug 2020 12:11:34 +0000
>Subject: [PATCH] Bug 25905: Tidy up warns
>
>---
> Koha/Import/Oaipmh.pm                 | 3 +++
> Koha/REST/V1/Import/Oaipmh/Biblios.pm | 2 --
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Import/Oaipmh.pm b/Koha/Import/Oaipmh.pm
>index 83ae6ca627..fff3e9200e 100644
>--- a/Koha/Import/Oaipmh.pm
>+++ b/Koha/Import/Oaipmh.pm
>@@ -124,6 +124,7 @@ sub process_metadata {
>                                             $skipped++;
>                                         }
>                                     };
>+                                    warn $@ if $@;
>                                 } elsif ($deleted){
>                                     eval {
>                                         C4::Biblio::DelBiblio($record->biblionumber);
>@@ -134,6 +135,7 @@ sub process_metadata {
>                                         #});
>                                         $deleted++;
>                                     };
>+                                    warn $@ if $@;
>                                 }
>                             } else {
>                                 #NOTE: Having metadata and being deleted should be mutually exclusive,
>@@ -154,6 +156,7 @@ sub process_metadata {
>                                         })->store;
>                                         $added++;
>                                     };
>+                                    warn $@ if $@;
>                                 }
>                             }
>                         }
>diff --git a/Koha/REST/V1/Import/Oaipmh/Biblios.pm b/Koha/REST/V1/Import/Oaipmh/Biblios.pm
>index 1e41f86715..f48607d830 100644
>--- a/Koha/REST/V1/Import/Oaipmh/Biblios.pm
>+++ b/Koha/REST/V1/Import/Oaipmh/Biblios.pm
>@@ -55,8 +55,6 @@ sub import_biblios {
>             records => $records,
>             frameworkcode => $frameworkcode,
>         });
>-        use Data::Dumper;
>-        warn Dumper($results);
>     } else {
>         return $c->render( status => 400, openapi => { error => "Records not found." } );
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25905: 107880 | 107881 | 107882 | 107883