Attachment 107968 Details for Bug 24201 – Bug 24201: (QA follow-up) Replace library select

[patch] Bug 24201: (QA follow-up) Replace library select

Bug-24201-QA-follow-up-Replace-library-select.patch (text/plain), 1.29 KB, created by Martin Renvoize (ashimema) on 2020-08-07 14:40:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-08-07 14:40:28 UTC

Size: 1.29 KB

patch

obsolete

>From e1a00b0d894fc9b81aea210655648e0bfba28522 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 7 Aug 2020 15:38:54 +0100
>Subject: [PATCH] Bug 24201: (QA follow-up) Replace library select
>
>Removing the library select entirely results in a JS failure for desk
>selection when independant branches is enabled and the user does not
>have permission to select a library.
>
>This patch adds a hidden select element so we can still grab the current
>branch from the selection.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt
>index 3d358bdb94..4859bdbcf6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt
>@@ -74,7 +74,12 @@ Updated:<ul>
>         </select></li>
>     </ol>
> </fieldset>
>+[% ELSE %]
>+<select name="branch" id="branch" style="visibility:hidden;">
>+    [% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %]
>+</select>
> [% END %]
>+
> [% IF Koha.Preference('UseCirculationDesks') && Desks.all %]
> <fieldset class="rows">
>     <legend>Set desk</legend>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24201: 96158 | 96164 | 96165 | 96166 | 101452 | 101564 | 101684 | 101697 | 101704 | 101705 | 101848 | 101865 | 101866 | 101877 | 101878 | 101879 | 101880 | 101881 | 101882 | 101883 | 103839 | 103840 | 105795 | 105869 | 105873 | 105874 | 105875 | 106576 | 107089 | 107090 | 107091 | 107092 | 107093 | 107094 | 107095 | 107096 | 107097 | 107667 | 107668 | 107669 | 107670 | 107671 | 107672 | 107673 | 107674 | 107675 | 107676 | 107677 | 107678 | 107679 | 107680 | 107728 | 107729 | 107730 | 107731 | 107732 | 107750 | 107751 | 107752 | 107815 | 107816 | 107817 | 107818 | 107951 | 107952 | 107967 | 107968 | 107980 | 107981