Attachment 10802 Details for Bug 8433 – Proposed Patch

[patch] Proposed Patch

0001-Bug-8433-Remove-unused-use-English.patch (text/plain), 2.33 KB, created by Colin Campbell on 2012-07-12 16:22:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Campbell

Created: 2012-07-12 16:22:28 UTC

Size: 2.33 KB

patch

obsolete

>From 5e4fc5489f1c3882f87cd5640e83b8a3a1e37244 Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Thu, 12 Jul 2012 17:11:14 +0100
>Subject: [PATCH] Bug 8433 Remove unused 'use English'
>
>Adding a use English to mosules which dont may
>waste a few CPU cycles and bytes of storage
>but doesnt add anything to the sum of human happiness
>
>Remove unnecessary use English's
>Removed already commented out but equally unnrcessary
>use Exporter in same modules
>---
> C4/SIP/Sip.pm                           | 1 -
> C4/SIP/Sip/Configuration.pm             | 1 -
> C4/SIP/Sip/Configuration/Account.pm     | 2 --
> C4/SIP/Sip/Configuration/Institution.pm | 2 --
> C4/SIP/Sip/Configuration/Service.pm     | 2 --
> 5 files changed, 8 deletions(-)
>
>diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm
>index 8807df6..7a3d257 100644
>--- a/C4/SIP/Sip.pm
>+++ b/C4/SIP/Sip.pm
>@@ -6,7 +6,6 @@ package Sip;
> 
> use strict;
> use warnings;
>-use English;
> use Exporter;
> use Readonly;
> 
>diff --git a/C4/SIP/Sip/Configuration.pm b/C4/SIP/Sip/Configuration.pm
>index 662e24c..9a281dd 100644
>--- a/C4/SIP/Sip/Configuration.pm
>+++ b/C4/SIP/Sip/Configuration.pm
>@@ -7,7 +7,6 @@
> package Sip::Configuration;
> 
> use strict;
>-use English;
> use warnings;
> use XML::Simple qw(:strict);
> 
>diff --git a/C4/SIP/Sip/Configuration/Account.pm b/C4/SIP/Sip/Configuration/Account.pm
>index 7b3d03e..1867a4c 100644
>--- a/C4/SIP/Sip/Configuration/Account.pm
>+++ b/C4/SIP/Sip/Configuration/Account.pm
>@@ -7,8 +7,6 @@ package Sip::Configuration::Account;
> 
> use strict;
> use warnings;
>-use English;
>-# use Exporter;
> 
> sub new {
>     my ($class, $obj) = @_;
>diff --git a/C4/SIP/Sip/Configuration/Institution.pm b/C4/SIP/Sip/Configuration/Institution.pm
>index 1e50af2..cd2c80c 100644
>--- a/C4/SIP/Sip/Configuration/Institution.pm
>+++ b/C4/SIP/Sip/Configuration/Institution.pm
>@@ -7,8 +7,6 @@ package Sip::Configuration::Institution;
> 
> use strict;
> use warnings;
>-use English;
>-# use Exporter;
> 
> sub new {
>     my ($class, $obj) = @_;
>diff --git a/C4/SIP/Sip/Configuration/Service.pm b/C4/SIP/Sip/Configuration/Service.pm
>index b5e37e8..34a02b1 100644
>--- a/C4/SIP/Sip/Configuration/Service.pm
>+++ b/C4/SIP/Sip/Configuration/Service.pm
>@@ -7,8 +7,6 @@ package Sip::Configuration::Service;
> 
> use strict;
> use warnings;
>-use English;
>-# use Exporter;
> 
> sub new {
>     my ($class, $obj) = @_;
>-- 
>1.7.11.1.165.g299666c
>

Actions: View | Diff | Splinter Review

Attachments on bug 8433: 10802 | 14242 | 14416