Attachment 108044 Details for Bug 22417 – Bug 22417: Send message to /queue

[patch] Bug 22417: Send message to /queue

Bug-22417-Send-message-to-queue.patch (text/plain), 2.08 KB, created by David Cook on 2020-08-11 08:18:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2020-08-11 08:18:54 UTC

Size: 2.08 KB

patch

obsolete

>From 94b3a187ef9bc34206f6fc79e7521ed5fc6aacad Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 12 Jun 2020 11:50:37 +0200
>Subject: [PATCH] Bug 22417: Send message to /queue
>
>This cannot be:
>  /queue/$namespace/$job_type
>
>I got: '/koha_kohadev/batch_biblio_record_modification' is not a valid queue destination
>
>So keeping the dash in $namespace-$job_type
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>---
> Koha/BackgroundJob.pm          | 2 +-
> misc/background_jobs_worker.pl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm
>index e53fd37dba..d4d4c2a59e 100644
>--- a/Koha/BackgroundJob.pm
>+++ b/Koha/BackgroundJob.pm
>@@ -55,7 +55,7 @@ sub enqueue {
>             # Also, here we just want the Koha instance's name, but it's not in the config...
>             # Picking a random id (memcached_namespace) from the config
>             my $namespace = C4::Context->config('memcached_namespace');
>-            $conn->send_with_receipt( { destination => sprintf("%s-%s", $namespace, $job_type), body => $json_args } )
>+            $conn->send_with_receipt( { destination => sprintf("/queue/%s-%s", $namespace, $job_type), body => $json_args } )
>               or Koha::Exceptions::Exception->throw('Job has not been enqueued');
>         }
>     );
>diff --git a/misc/background_jobs_worker.pl b/misc/background_jobs_worker.pl
>index 0127a2c2f1..d1b1ffd6ac 100755
>--- a/misc/background_jobs_worker.pl
>+++ b/misc/background_jobs_worker.pl
>@@ -27,7 +27,7 @@ my @job_types = qw( batch_biblio_record_modification batch_authority_record_modi
> # FIXME cf note in Koha::BackgroundJob about $namespace
> my $namespace = C4::Context->config('memcached_namespace');
> for my $job_type ( @job_types ) {
>-    $conn->subscribe({ destination => sprintf("%s-%s", $namespace, $job_type), ack => 'client' });
>+    $conn->subscribe({ destination => sprintf("/queue/%s-%s", $namespace, $job_type), ack => 'client' });
> }
> while (1) {
>     my $frame = $conn->receive_frame;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22417: 105542 | 105543 | 107385 | 107386 | 107387 | 107388 | 107389 | 107390 | 107391 | 107392 | 107393 | 107394 | 107395 | 107396 | 107397 | 107398 | 107399 | 107400 | 107401 | 107402 | 107403 | 107404 | 107405 | 107406 | 107481 | 107482 | 107682 | 108023 | 108024 | 108025 | 108026 | 108027 | 108028 | 108029 | 108030 | 108031 | 108032 | 108033 | 108034 | 108035 | 108036 | 108037 | 108038 | 108039 | 108040 | 108041 | 108042 | 108043 | 108044 | 108045 | 108046 | 108047 | 109270 | 109271 | 109319 | 109320 | 109321 | 109322 | 109323 | 109324 | 109325 | 109326 | 109327 | 109328 | 109329 | 109330 | 109331 | 109332 | 109333 | 109334 | 109335 | 109336 | 109337 | 109338 | 109339 | 109340 | 109341 | 109342 | 109343 | 109344 | 109345 | 109350 | 109351 | 109355 | 109390 | 109391 | 109392 | 109393 | 109394 | 109395 | 109396 | 109397 | 109398 | 109399 | 109400 | 109401 | 109402 | 109403 | 109404 | 109405 | 109406 | 109407 | 109408 | 109409 | 109410 | 109411 | 109412 | 109413 | 109414 | 109415 | 109416 | 109417 | 109418 | 109474 | 109475 | 109476 | 109477 | 110150 | 111091 | 111092 | 111093 | 111094 | 111095 | 111096 | 111097 | 111098 | 111099 | 111100 | 111101 | 111102 | 111103 | 111104 | 111105 | 111106 | 111107 | 111108 | 111109 | 111110 | 111111 | 111112 | 111113 | 111114 | 111115 | 111116 | 111117 | 111118 | 111119 | 111120 | 111121 | 111238 | 111239 | 111245