Bugzilla – Attachment 108052 Details for
Bug 26191
Relocate track_login call in Auth.pm (see 22543)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26191: Relocate track_login call in Auth.pm
Bug-26191-Relocate-tracklogin-call-in-Authpm.patch (text/plain), 1.48 KB, created by
Marcel de Rooy
on 2020-08-11 11:30:40 UTC
(
hide
)
Description:
Bug 26191: Relocate track_login call in Auth.pm
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-08-11 11:30:40 UTC
Size:
1.48 KB
patch
obsolete
>From dbc03056a3e395006a69b7dd35a8f386c7530f0f Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 11 Aug 2020 11:22:22 +0000 >Subject: [PATCH] Bug 26191: Relocate track_login call in Auth.pm >Content-Type: text/plain; charset=utf-8 > >This is a leftover from bug 22543. >Trivial move. > >Test plan: >Do not apply this patch. >Pick a user that has not yet logged in today. >Only login via the opac and immediately check if borrowers.datelastseen did not change. >Apply this patch, restart, flush etc. >Only login via the opac and verify again rightaway (no further opac actions). >Now datelastseen should have been changed already. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Auth.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 259b6d6063..3efd6fb5f9 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1202,6 +1202,8 @@ sub checkauth { > ); > } > >+ track_login_daily( $userid ); >+ > # In case, that this request was a login attempt, we want to prevent that users can repost the opac login > # request. We therefore redirect the user to the requested page again without the login parameters. > # See Post/Redirect/Get (PRG) design pattern: https://en.wikipedia.org/wiki/Post/Redirect/Get >@@ -1214,8 +1216,6 @@ sub checkauth { > exit; > } > >- track_login_daily( $userid ); >- > return ( $userid, $cookie, $sessionID, $flags ); > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26191
:
108052
|
111243