Attachment 108070 Details for Bug 25663 – Bug 25663: Add get_lostreturn_policy method to CirculationRules

[patch] Bug 25663: Add get_lostreturn_policy method to CirculationRules

Bug-25663-Add-getlostreturnpolicy-method-to-Circul.patch (text/plain), 1.82 KB, created by Tomás Cohen Arazi (tcohen) on 2020-08-11 13:51:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-08-11 13:51:51 UTC

Size: 1.82 KB

patch

obsolete

>From 052829f8f176308387dc6cca4f4914cbd5ed2e45 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 3 Jun 2020 12:59:21 +0100
>Subject: [PATCH] Bug 25663: Add get_lostreturn_policy method to
> CirculationRules
>
>This patch adds a new get_lostreturn_policy method to
>Koha::CirculationRules which returns a boolean to the caller which
>denotes whether a refund should be applied or not on the return of
>a lost item.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/CirculationRules.pm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
>diff --git a/Koha/CirculationRules.pm b/Koha/CirculationRules.pm
>index 790f30498d..9bf1ab860e 100644
>--- a/Koha/CirculationRules.pm
>+++ b/Koha/CirculationRules.pm
>@@ -426,6 +426,36 @@ sub get_onshelfholds_policy {
>     return $rule ? $rule->rule_value : 0;
> }
> 
>+=head3 get_lostreturn_policy
>+
>+  my $refund = Koha::CirculationRules->get_lostreturn_policy( { return_branch => $return_branch, item => $item } );
>+
>+=cut
>+
>+sub get_lostreturn_policy {
>+    my ( $class, $params ) = @_;
>+
>+    my $item   = $params->{item};
>+
>+    my $behaviour = C4::Context->preference( 'RefundLostOnReturnControl' ) // 'CheckinLibrary';
>+    my $behaviour_mapping = {
>+           CheckinLibrary => $params->{'return_branch'},
>+           ItemHomeBranch => $item->homebranch,
>+        ItemHoldingBranch => $item->holdingbranch
>+    };
>+
>+    my $branch = $behaviour_mapping->{ $behaviour };
>+
>+    my $rule = Koha::CirculationRules->get_effective_rule(
>+        {
>+            branchcode => $branch,
>+            rule_name  => 'refund',
>+        }
>+    );
>+
>+    return $rule ? $rule->rule_value : 1;
>+}
>+
> =head3 article_requestable_rules
> 
>     Return rules that allow article requests, optionally filtered by
>-- 
>2.28.0

Actions: View | Diff | Splinter Review

Attachments on bug 25663: 105524 | 105525 | 105526 | 105527 | 106105 | 106106 | 106107 | 106108 | 106823 | 106824 | 106825 | 107332 | 107333 | 107334 | 108069 | 108070 | 108071 | 111309