Bugzilla – Attachment 108086 Details for
Bug 26102
Javascript injection in intranet search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26102: Prevent XSS when To.json is used: catalogue/results.tt
Bug-26102-Prevent-XSS-when-Tojson-is-used-catalogu.patch (text/plain), 1.10 KB, created by
Owen Leonard
on 2020-08-11 15:49:54 UTC
(
hide
)
Description:
Bug 26102: Prevent XSS when To.json is used: catalogue/results.tt
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-08-11 15:49:54 UTC
Size:
1.10 KB
patch
obsolete
>From 9b97cad0f69b3e4ca0a811f93d29b8a3cfac0ffe Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 11 Aug 2020 12:57:48 +0000 >Subject: [PATCH] Bug 26102: Prevent XSS when To.json is used: > catalogue/results.tt > >To test, perform a search in the catalogue and verify that search term >highlighting works correctly. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 72cd9a00a4..9d22ec3b75 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -740,7 +740,7 @@ > [%- END -%] > > var search_result = { >- query_desc: "[% To.json( query_desc ) | $raw %]", >+ query_desc: "[% To.json( query_desc ) | html %]", > query_cgi: "[% query_cgi | html %]", > limit_cgi: "[% limit_cgi | html %]", > sort_cgi: "[% sort_cgi | html %]", >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26102
:
107579
|
108083
|
108084
|
108085
|
108086
|
108087
|
108088
|
108089
|
108090
|
119643
|
119644
|
119645
|
119646
|
119647
|
119648
|
119649
|
127669
|
127670
|
127671
|
127672
|
127673
|
127674
|
127675
|
128716
|
128717
|
128718
|
128719
|
128720
|
128721
|
128722
|
130931
|
130932
|
130933
|
130934
|
130935
|
130936
|
130999
|
131000
|
131001
|
131002
|
131003
|
131004