Attachment 108100 Details for Bug 21345 – Bug 21345: Patron records with attached files not obvious from patron details view

[patch] Bug 21345: Patron records with attached files not obvious from patron details view

Bug-21345-Patron-records-with-attached-files-not-o.patch (text/plain), 4.12 KB, created by Jonathan Druart on 2020-08-12 12:18:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-08-12 12:18:13 UTC

Size: 4.12 KB

patch

obsolete

>From 318785f003a02f6c1cd92fd334bc400ac6009b53 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 27 Jul 2020 15:57:40 +0000
>Subject: [PATCH] Bug 21345: Patron records with attached files not obvious
> from patron details view
>
>This patch adds a section to the patron details page for listing files
>which have been attached to the patron record.
>
>To test, apply the patch and enable the EnableBorrowerFiles system
>preference.
>
>- If necessary, attach some files to a patron record by viewing a patron
>  record and choosing "Files" from the sidebar menu.
>- View the detail page (moremember.pl) for a patron who has files
>  attached.
>- You should see a new section under "Alternative contact" with the
>  heading "Files."
>  - Test the "Manage" button to make sure it takes you to that patron's
>    files.
>  - Confirm that all the attached files are listed.
>  - Confirm that the links to each file work correctly.
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>
>Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>JD amended patch: replace a html filter with uri
>---
> .../prog/en/modules/members/moremember.tt     | 24 +++++++++++++++++++
> members/moremember.pl                         |  2 ++
> 2 files changed, 26 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 5803963479..d13fdd2da4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -700,6 +700,30 @@
>                                     </div>
>                                 [% END %]
>                             </div> [% # /div#patron-alternative-contact %]
>+
>+                            <div id="patron-files" class="patroninfo-section">
>+                                <div class="patroninfo-heading">
>+                                    <h3>Files</h3>
>+                                    <a class="btn btn-default btn-xs" href="/cgi-bin/koha/members/files.pl?borrowernumber=[% patron.borrowernumber | uri %]"><i class="fa fa-list"></i> Manage</a>
>+
>+                                    [% IF ( files ) %]
>+                                        <div class="rows">
>+                                            <ol>
>+                                                [% FOREACH f IN files %]
>+                                                    <li>
>+                                                        <a href="/cgi-bin/koha/members/files.pl?borrowernumber=[% patron.borrowernumber | uri %]&amp;op=download&amp;file_id=[% f.file_id | uri %]">[% f.file_name | html %]</a>
>+                                                        [% IF ( f.file_description ) %]
>+                                                            - [% f.file_description | html %]
>+                                                        [% END %]
>+                                                    </li>
>+                                                [% END # /FOREACH f %]
>+                                            </ol>
>+                                        </div>
>+                                    [% END # /IF files %]
>+
>+                                </div> 
>+                            </div> 
>+
>                         </div> 
>                     </div> 
> 
>diff --git a/members/moremember.pl b/members/moremember.pl
>index 93efa7a4b5..5d7d5227c8 100755
>--- a/members/moremember.pl
>+++ b/members/moremember.pl
>@@ -40,6 +40,7 @@ use Koha::Patron::Messages;
> use Koha::DateUtils;
> use Koha::CsvProfiles;
> use Koha::Patrons;
>+use Koha::Patron::Files;
> use Koha::Token;
> use Koha::Checkouts;
> 
>@@ -209,6 +210,7 @@ $template->param(
>     relatives_issues_count => $relatives_issues_count,
>     relatives_borrowernumbers => \@relatives,
>     logged_in_user => $logged_in_user,
>+    files => Koha::Patron::Files->new( borrowernumber => $borrowernumber ) ->GetFilesInfo(),
> );
> 
> output_html_with_http_headers $input, $cookie, $template->output;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21345: 107442 | 107623 | 107789 | 108018 | 108100 | 108157