Attachment 108152 Details for Bug 26132 – Bug 26132: (follow-up) Count all checkouts if no limits needed

[patch] Bug 26132: (follow-up) Count all checkouts if no limits needed

Bug-26132-follow-up-Count-all-checkouts-if-no-limi.patch (text/plain), 1.46 KB, created by Tomás Cohen Arazi (tcohen) on 2020-08-12 18:16:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-08-12 18:16:46 UTC

Size: 1.46 KB

patch

obsolete

>From 4891a05e7fa8ce673f231d224e380cd876ac8bf8 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 4 Aug 2020 19:01:30 +0000
>Subject: [PATCH] Bug 26132: (follow-up) Count all checkouts if no limits
> needed
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> C4/Circulation.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index c7245b815f..523dd7f603 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -437,12 +437,14 @@ sub TooMany {
>                 $checkouts = $patron->checkouts->search(
>                     { 'me.branchcode' => $maxissueqty_rule->branchcode } );
>             } elsif (C4::Context->preference('CircControl') eq 'PatronLibrary') {
>-                ; # if branch is the patron's home branch, then count all loans by patron
>+                $checkouts = $patron->checkouts; # if branch is the patron's home branch, then count all loans by patron
>             } else {
>                 $checkouts = $patron->checkouts->search(
>                     { 'item.homebranch' => $maxissueqty_rule->branchcode },
>                     { prefetch          => 'item' } );
>             }
>+        } else {
>+            $checkouts = $patron->checkouts; # if rule is not branch specific then count all loans by patron
>         }
>         my $sum_checkouts;
>         my $rule_itemtype = $maxissueqty_rule->itemtype;
>-- 
>2.28.0

Actions: View | Diff | Splinter Review

Attachments on bug 26132: 107734 | 107735 | 107736 | 107737 | 107738 | 107796 | 107797 | 107798 | 107799 | 107800 | 107801 | 108147 | 108148 | 108149 | 108150 | 108151 | 108152 | 108153 | 113006 | 113007 | 113014 | 113034