Attachment 108153 Details for Bug 26132 – Bug 26132: (QA follow-up) Make tests more robust

[patch] Bug 26132: (QA follow-up) Make tests more robust

Bug-26132-QA-follow-up-Make-tests-more-robust.patch (text/plain), 1.61 KB, created by Tomás Cohen Arazi (tcohen) on 2020-08-12 18:16:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-08-12 18:16:56 UTC

Size: 1.61 KB

patch

obsolete

>From 0eacdc6a3ffe825699f9ea4d993b569f9cf571c7 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 12 Aug 2020 14:44:52 -0300
>Subject: [PATCH] Bug 26132: (QA follow-up) Make tests more robust
>
>Tests fail is SearchEngine is set to Elasticsearch. This patch makes
>tests build 'real' biblios.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Koha/ItemTypes.t | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Koha/ItemTypes.t b/t/db_dependent/Koha/ItemTypes.t
>index 7f5e9e8188..22a8bd65a1 100755
>--- a/t/db_dependent/Koha/ItemTypes.t
>+++ b/t/db_dependent/Koha/ItemTypes.t
>@@ -124,13 +124,13 @@ my $item_type = $builder->build_object({ class => 'Koha::ItemTypes' });
> 
> is( $item_type->can_be_deleted, 1, 'An item type that is not used can be deleted');
> 
>-my $item = $builder->build_object({ class => 'Koha::Items', value => { itype => $item_type->itemtype }});
>+my $item = $builder->build_sample_item({ itype => $item_type->itemtype });
> is( $item_type->can_be_deleted, 0, 'An item type that is used by an item cannot be deleted' );
> $item->delete;
> 
>-my $biblioitem = $builder->build_object({ class => 'Koha::Biblioitems', value => { itemtype => $item_type->itemtype }});
>+my $biblio = $builder->build_sample_biblio({ itemtype => $item_type->itemtype });
> is ( $item_type->can_be_deleted, 0, 'An item type that is used by an item and a biblioitem cannot be deleted' );
>-$biblioitem->delete;
>+$biblio->delete;
> 
> is ( $item_type->can_be_deleted, 1, 'The item type that was being used by the removed item and biblioitem can now be deleted' );
> 
>-- 
>2.28.0

Actions: View | Diff | Splinter Review

Attachments on bug 26132: 107734 | 107735 | 107736 | 107737 | 107738 | 107796 | 107797 | 107798 | 107799 | 107800 | 107801 | 108147 | 108148 | 108149 | 108150 | 108151 | 108152 | 108153 | 113006 | 113007 | 113014 | 113034