Attachment 108187 Details for Bug 26204 – Bug 26204: Remove the use of jquery.checkboxes plugin from staff interface lists

[patch] Bug 26204: Remove the use of jquery.checkboxes plugin from staff interface lists

Bug-26204-Remove-the-use-of-jquerycheckboxes-plugi.patch (text/plain), 2.16 KB, created by Owen Leonard on 2020-08-13 14:01:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-08-13 14:01:29 UTC

Size: 2.16 KB

patch

obsolete

>From ed010488da50cfef91529d524442160f95cf8b27 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 13 Aug 2020 13:54:54 +0000
>Subject: [PATCH] Bug 26204: Remove the use of jquery.checkboxes plugin from
> staff interface lists
>
>This patch removes the use of the jquery.checkboxes plugin from the
>staff interface lists page.
>
>To test, apply the patch, go to Lists, and view the contents of a
>list with multiple titles on it.
>
>Check that the "Select all" and "Clear all" links work correctly.
>---
> .../prog/en/modules/virtualshelves/shelves.tt           | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index 5beada8871..fddb934918 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -544,13 +544,18 @@
>                 });
>                 $("span.clearall").html("<a id=\"CheckNone\" href=\"/cgi-bin/koha/shelves.pl\"><i class=\"fa fa-remove\"></i>"+_(" Clear all")+"<\/a>");
>                 $("span.checkall").html("<a id=\"CheckAll\" href=\"/cgi-bin/koha/shelves.pl\"><i class=\"fa fa-check\"></i>"+_(" Select all")+"<\/a>");
>-                $("#CheckAll").click(function(){
>-                    $(".checkboxed").checkCheckboxes();
>-                    return false;
>+                $("#CheckAll").click(function(e){
>+                    e.preventDefault();
>+                    $(".selection").each(function(){
>+                        $(this).prop("checked", true);
>+                    });
>                 });
>-                $("#CheckNone").click(function(){
>-                    $(".checkboxed").unCheckCheckboxes();
>-                    return false;
>+
>+                $("#CheckNone").click(function(e){
>+                    e.preventDefault();
>+                    $(".selection").each(function(){
>+                        $(this).prop("checked", false);
>+                    });
>                 });
>                 $(".placehold").on("click",function(e){
>                     placeHold();
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26204: 108187 | 108405 | 108424