Attachment 108190 Details for Bug 26175 – Bug 26175: Remove warn if undefined barcode in misc/export_records.pl

[patch] Bug 26175: Remove warn if undefined barcode in misc/export_records.pl

Bug-26175-Remove-warn-if-undefined-barcode-in-misc.patch (text/plain), 1.42 KB, created by Martin Renvoize (ashimema) on 2020-08-13 14:13:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-08-13 14:13:09 UTC

Size: 1.42 KB

patch

obsolete

>From 1d34d4e77eaec3aa4ca946f56dde264dbc74256a Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Fri, 7 Aug 2020 10:58:51 +0200
>Subject: [PATCH] Bug 26175: Remove warn if undefined barcode in
> misc/export_records.pl
>
>When using misc/export_records.pl --deleted_barcodes if barcode is NULL you get warn :
>Use of uninitialized value in say at /home/koha/src/misc/export_records.pl
>
>Also exporting barcode if empty string makes no sense.
>
>Test plan :
>1) Delete an item with barcode = NULL
>2) Run : misc/export_records.pl --date=`date +%d/%m/%Y` --deleted_barcodes --filename=/tmp/deleted_barcodes
>3) Check you se no warn "Use of uninitialized value in say ..."
>4) Delete an item with barcode = ''
>5) Run 2)
>6) Check there is no empty line in /tmp/deleted_barcodes
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> misc/export_records.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/misc/export_records.pl b/misc/export_records.pl
>index 4bd588aae8..2a05e794df 100755
>--- a/misc/export_records.pl
>+++ b/misc/export_records.pl
>@@ -242,6 +242,7 @@ if ($deleted_barcodes) {
>             SELECT DISTINCT barcode
>             FROM deleteditems
>             WHERE deleteditems.biblionumber = ?
>+            AND barcode IS NOT NULL AND barcode != ''
>         |, { Slice => {} }, $record_id );
>         say $_->{barcode} for @$barcode;
>     }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26175: 107947 | 108054 | 108190 | 111730