Attachment 108217 Details for Bug 19889 – Bug 19889: Add feedback when exclusion is updated on moredetail.pl

[patch] Bug 19889: Add feedback when exclusion is updated on moredetail.pl

Bug-19889-Add-feedback-when-exclusion-is-updated-o.patch (text/plain), 3.52 KB, created by Agustín Moyano on 2020-08-13 19:42:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Agustín Moyano

Created: 2020-08-13 19:42:01 UTC

Size: 3.52 KB

patch

obsolete

>From 9d0b7c992cb6e7d1146d0a8bc63e9d6d27abb5d7 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 22 Jul 2020 11:21:39 -0400
>Subject: [PATCH] Bug 19889: Add feedback when exclusion is updated on
> moredetail.pl
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> catalogue/moredetail.pl                                    | 4 ++++
> catalogue/updateitem.pl                                    | 5 ++++-
> .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt  | 7 +++++++
> 3 files changed, 15 insertions(+), 1 deletion(-)
>
>diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl
>index aca129468a..88d80cd348 100755
>--- a/catalogue/moredetail.pl
>+++ b/catalogue/moredetail.pl
>@@ -50,6 +50,10 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user(
>     }
> );
> 
>+$template->param(
>+    updated_exclude_from_local_holds_priority => $query->param('updated_exclude_from_local_holds_priority')
>+);
>+
> if($query->cookie("holdfor")){ 
>     my $holdfor_patron = Koha::Patrons->find( $query->cookie("holdfor") );
>     $template->param(
>diff --git a/catalogue/updateitem.pl b/catalogue/updateitem.pl
>index 9d112166d4..f8df6a2623 100755
>--- a/catalogue/updateitem.pl
>+++ b/catalogue/updateitem.pl
>@@ -56,6 +56,8 @@ for ($damaged,$itemlost,$withdrawn) {
>     }
> }
> 
>+my $alerts = q{};
>+
> # modify MARC item if input differs from items table.
> if ( $op eq "set_non_public_note" ) {
>     checkauth($cgi, 0, {editcatalogue => 'edit_items'}, 'intranet');
>@@ -74,6 +76,7 @@ elsif ( $op eq "set_public_note" ) { # i.e., itemnotes parameter passed from for
>     $item->withdrawn($withdrawn);
> } elsif ( $op eq "set_exclude_priority" && $exclude_from_local_holds_priority ne $item_data_hashref->{'exclude_from_local_holds_priority'}) {
>     $item->exclude_from_local_holds_priority($exclude_from_local_holds_priority);
>+    $alerts = "updated_exclude_from_local_holds_priority=$exclude_from_local_holds_priority&";
> } elsif ( $op eq "set_damaged" && $damaged ne $item_data_hashref->{'damaged'}) {
>     $item->damaged($damaged);
> } else {
>@@ -86,4 +89,4 @@ $item->store;
> 
> LostItem($itemnumber, 'moredetail') if $op eq "set_lost";
> 
>-print $cgi->redirect("moredetail.pl?biblionumber=$biblionumber&itemnumber=$itemnumber#item$itemnumber");
>+print $cgi->redirect("moredetail.pl?" . $alerts . "biblionumber=$biblionumber&itemnumber=$itemnumber#item$itemnumber");
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>index 397e879e16..862ff75367 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>@@ -55,6 +55,13 @@
>         <div class="dialog message">You are only viewing one item.  <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% biblionumber | uri %]&amp;bi=[% biblioitemnumber | uri %]#item[% itemnumber | uri %]">View All</a></div>
>     [% END %]
> 
>+    [% IF updated_exclude_from_local_holds_priority.defined %]
>+    <div class="dialog message">
>+        <i>Exclude from local holds priority</i> updated to
>+        [% IF updated_exclude_from_local_holds_priority %]<i>Yes</i>[% ELSE %]<i>No</i>[% END %]
>+    </div>
>+    [% END %]
>+
>     [% FOREACH ITEM_DAT IN ITEM_DATA %]
>         <div class="listgroup">
>         <h3 id="item[% ITEM_DAT.itemnumber | html %]">Barcode [% ITEM_DAT.barcode | html %]  [% IF ( ITEM_DAT.notforloantext ) %][% ITEM_DAT.notforloantext | html %] [% END %]</h3>
>-- 
>2.25.0

Actions: View | Diff | Splinter Review

Attachments on bug 19889: 105715 | 105716 | 105717 | 105718 | 106435 | 106436 | 106437 | 106438 | 106439 | 106440 | 106441 | 106442 | 107180 | 107187 | 107188 | 107189 | 107190 | 107191 | 107192 | 107193 | 107194 | 107195 | 107196 | 107908 | 107909 | 107910 | 107911 | 107912 | 107913 | 107926 | 107927 | 107928 | 107929 | 107930 | 107931 | 107948 | 108213 | 108214 | 108215 | 108216 | 108217 | 108218 | 108219 | 108220 | 108593 | 108594 | 108595 | 108725 | 108726 | 108728 | 109131 | 109132 | 109285 | 109364 | 109419