Attachment 108306 Details for Bug 26216 – Bug 26216: Remove the use of jquery.checkboxes plugin from catalog search results

[patch] Bug 26216: Remove the use of jquery.checkboxes plugin from catalog search results

Bug-26216-Remove-the-use-of-jquerycheckboxes-plugi.patch (text/plain), 2.67 KB, created by Owen Leonard on 2020-08-14 17:48:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-08-14 17:48:59 UTC

Size: 2.67 KB

patch

obsolete

>From 951380e8050d9aa18401d5100ad2a395df0f23f1 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 14 Aug 2020 17:28:22 +0000
>Subject: [PATCH] Bug 26216: Remove the use of jquery.checkboxes plugin from
> catalog search results
>
>This patch removes the use of jquery.checkboxes plugin from the
>staff interface catalog search results page.
>
>To test, apply the patch and perform a catalog search in the staff
>interface which will return results.
>
>On the search results page test the "Select all" and "Clear all" links
>at the top of the results. They should work correctly.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt |  1 -
> koha-tmpl/intranet-tmpl/prog/js/pages/results.js             | 10 +++-------
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index 72cd9a00a4..b8b45d61a3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -707,7 +707,6 @@
>     [% INCLUDE 'strings.inc' %]
>     [% Asset.js("js/browser.js") | $raw %]
>     [% Asset.js("lib/hc-sticky.js") | $raw %]
>-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
>     [% Asset.js("js/coce.js") | $raw %]
>     <script>
>         var MSG_NO_ITEM_SELECTED = _("Nothing is selected.");
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js
>index 6c3a488575..d9978b08df 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js
>@@ -164,7 +164,7 @@ $(document).ready(function() {
>         }
>     });
>     $("#bookbag_form").ready(function(){
>-        $("#bookbag_form").unCheckCheckboxes();
>+        $("#bookbag_form input:checkbox").prop("checked", false);
>         var bibnums = getContextBiblioNumbers();
>         if (bibnums) {
>             for (var i=0; i < bibnums.length; i++) {
>@@ -211,18 +211,14 @@ function highlightOn() {
> 
> 
> function selectAll () {
>-    $("#bookbag_form").checkCheckboxes();
>     $("#bookbag_form").find("input[type='checkbox'][name='biblionumber']").each(function(){
>-        $(this).change();
>+        $(this).prop("checked", true ).change();
>     } );
>-    return false;
> }
> function clearAll () {
>-    $("#bookbag_form").unCheckCheckboxes();
>     $("#bookbag_form").find("input[type='checkbox'][name='biblionumber']").each(function(){
>-        $(this).change();
>+        $(this).prop("checked", false).change();
>     } );
>-    return false;
> }
> function placeHold () {
>     var checkedItems = $(".selection:checked");
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26216: 108306 | 108365 | 108376