Bugzilla – Attachment 10831 Details for
Bug 8434
Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8434 - Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm)
Bug-8434---Notice-generation-fails-for-Advanced-No.patch (text/plain), 1.16 KB, created by
Kyle M Hall (khall)
on 2012-07-13 16:53:07 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8434 - Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm)
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-07-13 16:53:07 UTC
Size:
1.16 KB
patch
obsolete
>From 388ef376d7eca4c5afc3df6ab74ceaab54189f55 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Fri, 13 Jul 2012 11:50:04 +1000 >Subject: [PATCH] Bug 8434 - Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm) > >Patch introduces a check for C4::Context->userenv in Letters.pm, so that script doesn't fail when it calls to C4::Context->userenv->{branch}, when run from shell. > >Without the check, Advanced Notices, Item Due, and Overdues fail to generate. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Letters.pm | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 893419c..d13ce13 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -121,7 +121,9 @@ sub getletter ($$$) { > my ( $module, $code, $branchcode ) = @_; > > if (C4::Context->preference('IndependantBranches') && $branchcode){ >+ if (C4::Context->userenv) { > $branchcode = C4::Context->userenv->{'branch'}; >+ } > } > > if ( my $l = $letter{$module}{$code}{$branchcode} ) { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8434
:
10805
|
10806
|
10831
|
11078