Bugzilla – Attachment 108311 Details for
Bug 25751
When an ORDERED suggestion is edited, the status resets to "No status"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25751: Add ORDERED in dropdown list of suggestion's statuses
Bug-25751-Add-ORDERED-in-dropdown-list-of-suggesti.patch (text/plain), 3.51 KB, created by
Katrin Fischer
on 2020-08-15 07:40:25 UTC
(
hide
)
Description:
Bug 25751: Add ORDERED in dropdown list of suggestion's statuses
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-08-15 07:40:25 UTC
Size:
3.51 KB
patch
obsolete
>From c0036edc9c6594afec32bcf88a59c7a030a96b26 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 16 Jun 2020 15:44:40 +0200 >Subject: [PATCH] Bug 25751: Add ORDERED in dropdown list of suggestion's > statuses > >The status "ORDERED" is missing from the pull down list of >status values when editing a suggestion, so the first >option is selected "No status". > >This leads to data loss when editing a suggestion in the >status "ORDERED". Worse: the status can't be reset to >"ORDERED" and so no AVAILABLE notice can be sent to the patron. > >Test plan: >- Create a suggestion, accept it, create a new order from this suggestion. >- Verify status is "ORDERED" >- Edit the suggestion >=> Without this patch the dropdown list does not have > "Ordered", and if you save you lost the status >=> With this patch applied the dropdown list has "Ordered" > preselected. You can save and preserve the status. > >Signed-off-by: Holly Cooper <hc@interleaf.ie> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/suggestion/suggestion.tt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index c293a57ba3..02321e8615 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -343,6 +343,12 @@ > <option value="REJECTED">Rejected</option> > [% END %] > >+ [% IF ( statusselected_ORDERED ) %] >+ <option value="ORDERED" selected="selected">Ordered</option> >+ [% ELSE %] >+ <option value="ORDERED">Ordered</option> >+ [% END %] >+ > [% FOREACH s IN SuggestionStatuses %] > [% IF s.authorised_value == suggestion.STATUS %] > <option value="[% s.authorised_value | html %]" selected="selected">[% s.lib | html %]</option> >@@ -681,6 +687,12 @@ > <option value="REJECTED">Rejected</option> > [% END %] > >+ [% IF ( statusselected_ORDERED ) %] >+ <option value="ORDERED" selected="selected">Ordered</option> >+ [% ELSE %] >+ <option value="ORDERED">Ordered</option> >+ [% END %] >+ > [% FOREACH s IN SuggestionStatuses %] > <option value="[% s.authorised_value | html %]">[% s.lib | html %]</option> > [% END %] >@@ -841,6 +853,12 @@ > <option value="REJECTED">Rejected</option> > [% END %] > >+ [% IF ( statusselected_ORDERED ) %] >+ <option value="ORDERED" selected="selected">Ordered</option> >+ [% ELSE %] >+ <option value="ORDERED">Ordered</option> >+ [% END %] >+ > [% FOREACH s IN SuggestionStatuses %] > [% IF s.authorised_value == selected_status %] > <option value="[% s.authorised_value | html %]" selected="selected">[% s.lib | html %]</option> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25751
:
105918
|
107893
| 108311