Attachment 108329 Details for Bug 19036 – Bug 19036: (QA follow-up) Add credit_number handling to POS

[patch] Bug 19036: (QA follow-up) Add credit_number handling to POS

Bug-19036-QA-follow-up-Add-creditnumber-handling-t.patch (text/plain), 6.63 KB, created by Katrin Fischer on 2020-08-15 12:45:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-08-15 12:45:06 UTC

Size: 6.63 KB

patch

obsolete

>From 751147d83e03d485f66f2b82dec052dbdea649c6 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 6 Aug 2020 12:28:48 +0100
>Subject: [PATCH] Bug 19036: (QA follow-up) Add credit_number handling to POS
>
>This patch adds the display of 'credit_number' as a replacement for the
>internal 'accountlines_id' as the transaction identifier on the
>register summary page when using cash registers.
>
>Test plan
>1/ Enable 'UseCashRegisters'
>2/ Enable 'EnablePointOfSale'
>3/ Enable at least one 'Debit type' to allow 'sale'
>4/ Add at least one 'Cash register'
>5/ Enable 'AutoCreditNumber'
>6/ 'Enable automatic generation of credit number' for the 'Purchase'
>credit type
>7/ Pay for an item via the Point of Sale page
>8/ Navigate to the 'register' page to display the purchase details
>9/ Confirm that the 'Transaction' is listed with a number of the form
>specified in the 'AutoCreditNumber' preference
>10/ Refund an item from this screen
>11/ Note that the 'accountlines_id' is used for this refund as we did
>not specify the 'Refund' credit type to use the 'AutoCreditNumber'
>system
>12/ Signoff
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
>index 2d96682a2f..e5a350f5c9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
>@@ -69,7 +69,7 @@
>                             [% IF credit.debit %]
>                             <tr>
>                                 <td>[% accountline.accountlines_id | html %]</td>
>-                                <td>{ "type": "credit", "description": "[%- PROCESS account_type_description account=accountline -%] ([% accountline.payment_type | html %])", "amount": "[% accountline.amount * -1 | $Price %]" }</td>
>+                                <td>{ "type": "credit", "identifier": "[%- accountline.credit_number | html -%]", "description": "[%- PROCESS account_type_description account=accountline -%] ([% accountline.payment_type | html %])", "amount": "[% accountline.amount * -1 | $Price %]" }</td>
>                                 <td></td>
>                                 <td>
>                                     [%- PROCESS account_type_description account=credit.debit -%]
>@@ -93,7 +93,7 @@
>                             [% IF debit.credit %]
>                             <tr>
>                                 <td>[% accountline.accountlines_id | html %]</td>
>-                                <td>{ "type": "debit", "description": "[%- PROCESS account_type_description account=accountline -%] ([% accountline.payment_type | html %])", "amount": "[% accountline.amount * -1 | $Price %]" }</td>
>+                                <td>{ "type": "debit", "identifier": "[%- accountline.credit_number | html -%]", "description": "[%- PROCESS account_type_description account=accountline -%] ([% accountline.payment_type | html %])", "amount": "[% accountline.amount * -1 | $Price %]" }</td>
>                                 <td></td>
>                                 <td>[%- PROCESS account_type_description account=debit.credit -%]</td>
>                                 <td>
>@@ -158,7 +158,7 @@
>                             [% IF credit.debit %]
>                             <tr>
>                                 <td>[% accountline.accountlines_id | html %]</td>
>-                                <td>{ "type": "credit", "description": "[%- PROCESS account_type_description account=accountline -%] ([% accountline.payment_type | html %])", "amount": "[% accountline.amount * -1 | $Price %]" }</td>
>+                                <td>{ "type": "credit", "identifier": "[%- accountline.credit_number | html -%]", "description": "[%- PROCESS account_type_description account=accountline -%] ([% accountline.payment_type | html %])", "amount": "[% accountline.amount * -1 | $Price %]" }</td>
>                                 <td></td>
>                                 <td>
>                                     [%- PROCESS account_type_description account=credit.debit -%]
>@@ -180,7 +180,7 @@
>                             [% IF debit.credit %]
>                             <tr>
>                                 <td>[% accountline.accountlines_id | html %]</td>
>-                                <td>{ "type": "debit", "description": "[%- PROCESS account_type_description account=accountline -%] ([% accountline.payment_type | html %])", "amount": "[% accountline.amount * -1 | $Price %]" }</td>
>+                                <td>{ "type": "debit", "identifier": "[%- accountline.credit_number | html -%]", "description": "[%- PROCESS account_type_description account=accountline -%] ([% accountline.payment_type | html %])", "amount": "[% accountline.amount * -1 | $Price %]" }</td>
>                                 <td></td>
>                                 <td>[%- PROCESS account_type_description account=debit.credit -%]</td>
>                                 <td>[%- IF debit.credit.description %][% debit.credit.description | html %][% END %]
>@@ -298,8 +298,9 @@
>                 dataSrc: 0,
>                 startRender: function ( rows, group ) {
>                     var details = JSON.parse(rows.data().pluck(1).pop());
>+                    var identifier = details.identifier || group;
>                     return $('<tr class="'+details.type+'"/>')
>-                        .append( '<td>'+group+'</td>' )
>+                        .append( '<td>'+identifier+'</td>' )
>                         .append( '<td colspan="2">'+details.description+'</td>' )
>                         .append( '<td>'+details.amount+'</td>' )
>                         .append( '<td><button class="printReceipt btn btn-default btn-xs" data-accountline="'+group+'"><i class="fa fa-print"></i> ' + _("Print receipt") + '</button></td>');
>@@ -318,8 +319,9 @@
>                 dataSrc: 0,
>                 startRender: function ( rows, group ) {
>                     var details = JSON.parse(rows.data().pluck(1).pop());
>+                    var identifier = details.identifier || group;
>                     return $('<tr class="'+details.type+'"/>')
>-                        .append( '<td>'+group+'</td>' )
>+                        .append( '<td>'+identifier+'</td>' )
>                         .append( '<td colspan="2">'+details.description+'</td>' )
>                         .append( '<td>'+details.amount+'</td>' )
>                         .append( '<td><button class="printReceipt btn btn-default btn-xs" data-accountline="'+group+'"><i class="fa fa-print"></i> Print receipt</button></td>');
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19036: 99301 | 99302 | 99303 | 99676 | 101549 | 101550 | 101896 | 101897 | 106278 | 106279 | 106280 | 106281 | 106767 | 107872 | 107875 | 107877 | 108323 | 108324 | 108325 | 108326 | 108327 | 108328 | 108329 | 108525 | 108587 | 108733