Attachment 108406 Details for Bug 26202 – Bug 26202: Remove the use of jquery.checkboxes plugin from batch record modification page

[patch] Bug 26202: Remove the use of jquery.checkboxes plugin from batch record modification page

0001-Bug-26202-Remove-the-use-of-jquery.checkboxes-plugin.patch (text/plain), 2.37 KB, created by Amit Gupta on 2020-08-17 15:50:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Amit Gupta

Created: 2020-08-17 15:50:41 UTC

Size: 2.37 KB

patch

obsolete

>From 2ae096789d4f4fe8d628f27698df24e8e72287d0 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 13 Aug 2020 13:19:19 +0000
>Subject: [PATCH] Bug 26202: Remove the use of jquery.checkboxes plugin from
> batch record modification page
>
>This patch removes the use of the jquery.checkboxes plugin from the
>batch record modification page.
>
>To test, apply the patch and go to Tools -> Batch record modification
>
> - Submit a batch of biblionumbers for modification.
> - On the results page, test the "Select all" and "Clear all" links to
>   confirm that they work correctly.
>
>Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
>---
> .../prog/en/modules/tools/batch_record_modification.tt   | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>index 66de6f4..19aab27 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>@@ -302,7 +302,6 @@
> [% MACRO jsinclude BLOCK %]
>     [% Asset.js("js/tools-menu.js") | $raw %]
>     [% INCLUDE 'datatables.inc' %]
>-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
>     [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %]
>     [% Asset.js("js/background-job-progressbar.js") | $raw %]
>     <script>
>@@ -317,14 +316,21 @@
>                     $("#show_list_option").show();
>                 }
>             });
>-            $("#selectall").click(function(e) {
>+
>+            $("#selectall").click(function(e){
>                 e.preventDefault();
>-                $(".records").checkCheckboxes();
>+                $(".records input[type='checkbox']").each(function(){
>+                    $(this).prop("checked", true);
>+                });
>             });
>-            $("#clearall").click(function(e) {
>+
>+            $("#clearall").click(function(e){
>                 e.preventDefault();
>-                $(".records").unCheckCheckboxes();
>+                $(".records input[type='checkbox']").each(function(){
>+                    $(this).prop("checked", false);
>+                });
>             });
>+
>             $("#selectall").click();
> 
>             $("table#biblios").dataTable($.extend(true, {}, dataTablesDefaults, {
>-- 
>2.7.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 26202: 108181 | 108406 | 108423