Attachment 108412 Details for Bug 26201 – Bug 26201: Remove the use of jquery.checkboxes plugin from batch extend due dates page

[patch] Bug 26201: Remove the use of jquery.checkboxes plugin from batch extend due dates page

0001-Bug-26201-Remove-the-use-of-jquery.checkboxes-plugin.patch (text/plain), 3.59 KB, created by Amit Gupta on 2020-08-17 16:11:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Amit Gupta

Created: 2020-08-17 16:11:05 UTC

Size: 3.59 KB

patch

obsolete

>From 591487d289d76b860385cccf776dcbb989230a2c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 13 Aug 2020 12:34:19 +0000
>Subject: [PATCH] Bug 26201: Remove the use of jquery.checkboxes plugin from
> batch extend due dates page
>
>This patch removes the use of the jquery.checkboxes plugin from the
>batch extend due dates page.
>
>Unrelated change: Removed 'enctype="multipart/form-data"' from the form
>because there is no file upload.
>
>To test, apply the patch and go to Tools -> Batch extend due dates.
>
> - Submit the form with parameters which will return a set of multiple
>   checkouts.
> - On the results page, test the "Select all" and "Clear all" links to
>   confirm that they work correctly.
>
>Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
>---
> .../prog/en/modules/tools/batch_extend_due_dates.tt | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt
>index e572b2b..3736f99 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt
>@@ -51,7 +51,7 @@
>                     [% END %]
> 
>                     [% IF view == 'form' %]
>-                        <form method="post" enctype="multipart/form-data" action="/cgi-bin/koha/tools/batch_extend_due_dates.pl" id="extend_due_dates_form">
>+                        <form method="post" action="/cgi-bin/koha/tools/batch_extend_due_dates.pl" id="extend_due_dates_form">
>                             <fieldset class="rows">
>                                 <legend>Checkout criteria:</legend>
>                                 <ol>
>@@ -198,22 +198,27 @@
>     [% Asset.js("js/tools-menu.js") | $raw %]
>     [% INCLUDE 'calendar.inc' %]
>     [% INCLUDE 'datatables.inc' %]
>-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
>     [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %]
>     <script>
>         $(document).ready(function() {
> 
>-            $("#selectall").click(function(e) {
>+            $("#selectall").click(function(e){
>                 e.preventDefault();
>-                $("#checkouts").checkCheckboxes();
>+                $("#checkouts input[type='checkbox']").each(function(){
>+                    $(this).prop("checked", true);
>+                });
>             });
>-            $("#clearall").click(function(e) {
>+
>+            $("#clearall").click(function(e){
>                 e.preventDefault();
>-                $("#checkouts").unCheckCheckboxes();
>+                $("#checkouts input[type='checkbox']").each(function(){
>+                    $(this).prop("checked", false);
>+                });
>             });
>+
>             $("#selectall").click();
> 
>-            $("table#checkouts").dataTable($.extend(true, {}, dataTablesDefaults, {
>+            $("#checkouts").dataTable($.extend(true, {}, dataTablesDefaults, {
>                 "aoColumnDefs": [
>                     { "aTargets": [0, 3], "bSortable": false, "bSearchable": false },
>                     { "aTargets": [1], "sType": "num-html" }
>@@ -223,7 +228,7 @@
>                 "bPaginate": false
>             }));
> 
>-            $("table#checkouts_result").dataTable($.extend(true, {}, dataTablesDefaults, {
>+            $("#checkouts_result").dataTable($.extend(true, {}, dataTablesDefaults, {
>                 "aoColumnDefs": [
>                     { "aTargets": [0, 3], "bSortable": false, "bSearchable": false },
>                     { "aTargets": [1], "sType": "num-html" }
>-- 
>2.7.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 26201: 108175 | 108412 | 108419