Bugzilla – Attachment 108439 Details for
Bug 25242
Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25242: (QA follow-up) Colwidth on results table
Bug-25242-QA-follow-up-Colwidth-on-results-table.patch (text/plain), 2.73 KB, created by
Martin Renvoize (ashimema)
on 2020-08-18 09:39:53 UTC
(
hide
)
Description:
Bug 25242: (QA follow-up) Colwidth on results table
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-08-18 09:39:53 UTC
Size:
2.73 KB
patch
obsolete
>From f77d1b392d205d1e3852dcb9e43f8690399fa9fc Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 18 Aug 2020 10:35:59 +0100 >Subject: [PATCH] Bug 25242: (QA follow-up) Colwidth on results table > >Prior to this patch, the column width on the opac-results table were not >fixed or calculated by a datatable; As such when we introduced the >'table-layout: fixed' property all columns were given equal share of the >table, which resulted in most cases in a three way split between a >checkbox, an empty cell and the actual content. > >This patch sets the width for the selectcol to '1ch' for the single >character checkbox and updates the second columns class to 'numcol' as >it is not used for selection but rather result numbering and sets a >fixed width of '4ch' allowing for results upto 3 digits (plus the >period) to display correctly without wrapping. > >Test plan >1/ Apply the patches and run the yarn build process to update the .css >2/ Perform a search and varify that the results table looks reasonable >3/ Disable OPACHiddenItems and perform a search again. >4/ Confirm the table looks reasonable still >5/ Signoff >--- > koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 8 ++++++++ > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >index e59ab8d173..dfc4c6e6e3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >@@ -229,6 +229,14 @@ td { > background-color: #FFF; > word-wrap: break-all; > word-wrap: break-word; >+ >+ &.selectcol { >+ width: 1ch; >+ } >+ >+ &.numcol { >+ width: 3ch; >+ } > } > > tr { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index e199aa77bf..8f8aa642bc 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -261,7 +261,7 @@ > [% END # IF opacbookbag%] > </td> > [% # Cell 2: Show result number if OpacHiddenItems is empty %] >- <td class="select selectcol"> >+ <td class="numcol[%- IF suppress_result_number %] hidden[%- END -%]"> > [% UNLESS suppress_result_number %] > [% SEARCH_RESULT.result_number | html %]. > [% END %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25242
:
107884
|
107897
|
108348
|
108438
|
108439
|
108574
|
109444
|
109654
|
109663
|
109994