Bugzilla – Attachment 108506 Details for
Bug 26236
log viewer does not translate the interface properly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25872: Fix translating interface from DB term to readable term
Bug-25872-Fix-translating-interface-from-DB-term-t.patch (text/plain), 1.63 KB, created by
Nick Clemens (kidclamp)
on 2020-08-18 13:38:37 UTC
(
hide
)
Description:
Bug 25872: Fix translating interface from DB term to readable term
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-08-18 13:38:37 UTC
Size:
1.63 KB
patch
obsolete
>From 4ca3c8bd58a40618743f54a1754ae044019b7210 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 18 Aug 2020 13:33:33 +0000 >Subject: [PATCH] Bug 25872: Fix translating interface from DB term to readable > term > >When viewing the logs we try to swith the db values like 'cron' to friendly terms like >'Cron job' > >The values we use for building the selectors on the page ar eupper case, but DB values are lower case > >If we simply force upper case in the comparison we can ensure we always match correctly > >To test: >1 - Enable some 'Logs' setting in System preferences >2 - Perform some action in koha that will log > Run a cronjob > Change a syspref > etc. >3 - Browse to Tools-> Log viewer >4 - Click 'Submit' to see all logs >5 - Note the 'Interface' column contains lower case DB values >6 - Apply patch >7 - Reload the page >8 - Values in interface are now Camel cased and more friendly > >https://bugs.koha-community.org/show_bug.cgi?id=26236 >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >index 58e8b54914..85090b3ccb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >@@ -81,7 +81,7 @@ fieldset.rows label.viewlog { > [% END %] > > [% BLOCK translate_log_interface %] >-[% SWITCH log_interface %] >+[% SWITCH log_interface.upper %] > [% CASE 'INTRANET' %]Intranet > [% CASE 'OPAC' %]OPAC > [% CASE 'SIP' %]SIP >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26236
:
108506
|
109586
|
109595
|
109596