Attachment 108564 Details for Bug 26153 – Bug 26153: Remove the use of jquery.checkboxes plugin from items lost report

[patch] Bug 26153: Remove the use of jquery.checkboxes plugin from items lost report

Bug-26153-Remove-the-use-of-jquerycheckboxes-plugi.patch (text/plain), 2.42 KB, created by Katrin Fischer on 2020-08-18 22:13:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-08-18 22:13:20 UTC

Size: 2.42 KB

patch

obsolete

>From a46cdbf57fcdfcf4726e46285dd7f00d90eee055 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 5 Aug 2020 18:24:08 +0000
>Subject: [PATCH] Bug 26153: Remove the use of jquery.checkboxes plugin from
> items lost report
>
>This patch removes the use of the jquery.checkboxes plugin from the
>lost items report page and replaces it with custom JS.
>
>To test, apply the patch and go to Reports -> Lost items.
>
>- Run the report with parameters which will return multiple results.
>- On the results page Create a CSV export profile if there's none.
>- On the results page test the "Select all" and "Clear all"
>  links at the top of the results. The controls should work correctly.
>
>Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
>index 10d1141cc8..8852e31092 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
>@@ -183,7 +183,6 @@
>     [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %]
>     [% INCLUDE 'columns_settings.inc' %]
>     [% Asset.js("js/table_filters.js") | $raw %]
>-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
>     <script>
>         $(document).ready(function() {
>             var columns_settings = [% TablesSettings.GetColumns( 'reports', 'lostitems', 'lostitems-table', 'json' ) | $raw %];
>@@ -233,13 +232,17 @@
> 
>             $(".SelectAll").on("click",function(e){
>                 e.preventDefault();
>-                $("#lostitems-table").checkCheckboxes();
>+                $("#lostitems-table input:checkbox").each(function(){
>+                    $(this).prop("checked", true);
>+                });
>                 itemSelectionBuildActionLinks();
>             });
> 
>             $(".ClearAll").on("click",function(e){
>                 e.preventDefault();
>-                $("#lostitems-table").unCheckCheckboxes();
>+                $("#lostitems-table input:checkbox").each(function(){
>+                    $(this).prop("checked", false);
>+                });
>                 itemSelectionBuildActionLinks();
>             });
>         });
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26153: 107857 | 108442 | 108564