Bugzilla – Attachment 108581 Details for
Bug 18501
Automatic refunds need protection from failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18501: wip - need to know it has been refunded
Bug-18501-wip---need-to-know-it-has-been-refunded.patch (text/plain), 1.92 KB, created by
Martin Renvoize (ashimema)
on 2020-08-19 10:41:51 UTC
(
hide
)
Description:
Bug 18501: wip - need to know it has been refunded
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-08-19 10:41:51 UTC
Size:
1.92 KB
patch
obsolete
>From 4c7085c8acf143f89406e57686588a22aff4d171 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 14 Aug 2020 09:56:41 +0200 >Subject: [PATCH] Bug 18501: wip - need to know it has been refunded > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Circulation.pm | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index dfdbb1a5fa..fcd0cee3f9 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2012,8 +2012,18 @@ sub AddReturn { > $item->holdingbranch($branch)->store; > } > >+ my $item_was_lost = $item->itemlost; > my $leave_item_lost = C4::Context->preference("BlockReturnOfLostItems") ? 1 : 0; >- ModDateLastSeen( $item->itemnumber, $leave_item_lost ); >+ ModDateLastSeen( $item->itemnumber, $leave_item_lost ); # will unset itemlost if needed >+ >+ # fix up the accounts..... >+ if ( $item_was_lost ) { >+ $messages->{'WasLost'} = 1; >+ unless ( C4::Context->preference("BlockReturnOfLostItems") ) { >+ #my $refunded = Koha::Account::Lines->search{(itemnumber => $item->itemnumber, type => 'LOST_FOUND', # FIXME which other parameters to know it has been refunded? >+ $messages->{'LostItemFeeRefunded'} = 1; >+ } >+ } > > # check if we have a transfer for this document > my ($datesent,$frombranch,$tobranch) = GetTransfers( $item->itemnumber ); >@@ -2035,14 +2045,6 @@ sub AddReturn { > } > } > >- # fix up the accounts..... >- if ( $item->itemlost ) { >- $messages->{'WasLost'} = 1; >- unless ( C4::Context->preference("BlockReturnOfLostItems") ) { >- $messages->{'LostItemFeeRefunded'} = $refunded; >- } >- } >- > # fix up the overdues in accounts... > if ($borrowernumber) { > my $fix = _FixOverduesOnReturn( $borrowernumber, $item->itemnumber, $exemptfine, 'RETURNED' ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18501
:
108004
|
108005
|
108006
|
108121
|
108122
|
108123
|
108167
|
108168
|
108169
|
108170
|
108193
|
108194
|
108195
|
108243
|
108248
|
108249
|
108291
|
108292
|
108293
|
108294
|
108295
|
108296
|
108297
|
108298
|
108299
|
108300
|
108301
|
108482
|
108483
|
108484
|
108485
|
108486
|
108487
|
108488
|
108489
|
108490
|
108491
|
108492
|
108493
|
108494
|
108575
|
108576
|
108577
|
108578
|
108579
|
108580
|
108581
|
108582
|
108583
|
108584
|
108585
|
108586
|
108596
|
108597
|
108598
|
108599
|
108600
|
108601
|
108602
|
108603
|
108604
|
108605
|
108606
|
108607
|
108608
|
108610
|
108611
|
108612
|
108613
|
108614
|
108615
|
108616
|
108617
|
108618
|
108619
|
108620
|
108621
|
108717
|
108732
|
108738
|
108739
|
108740
|
108741
|
108784
|
108785
|
108786
|
108787
|
108788
|
108795
|
111295