Attachment 108595 Details for Bug 19889 – Bug 19889: (QA follow-up) use em over i and update field if unset

[patch] Bug 19889: (QA follow-up) use em over i and update field if unset

Bug-19889-QA-follow-up-use-em-over-i-and-update-fi.patch (text/plain), 2.20 KB, created by Nick Clemens (kidclamp) on 2020-08-19 12:24:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-08-19 12:24:14 UTC

Size: 2.20 KB

patch

obsolete

>From 31914ae5ba8ddf98f5f1e54c99674f694884e1d8 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 19 Aug 2020 12:21:27 +0000
>Subject: [PATCH] Bug 19889: (QA follow-up) use em over i and update field if
> unset
>
>em is better for accessibility
>
>We should set the field to 0 when it was previously unset
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 6 +++---
> tools/batchMod.pl | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>index ea1a2d5f9d..5cde5134a7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>@@ -60,11 +60,11 @@
> 
> [% IF updated_exclude_from_local_holds_priority.defined %]
> <div class="dialog message">
>- Exclude from local holds priority updated to
>+ Exclude from local holds priority updated to
> [% IF updated_exclude_from_local_holds_priority %]
>- Yes
>+ Yes
> [% ELSE %]
>- No
>+ No
> [% END %]
> </div>
> [% END %]
>diff --git a/tools/batchMod.pl b/tools/batchMod.pl
>index 719848f418..7299fc9d93 100755
>--- a/tools/batchMod.pl
>+++ b/tools/batchMod.pl
>@@ -242,7 +242,7 @@ if ($op eq "action") {
> else {
> my $modified_holds_priority = 0;
> if (defined $exclude_from_local_holds_priority) {
>- if($item->exclude_from_local_holds_priority != $exclude_from_local_holds_priority) {
>+ if(!defined $item->exclude_from_local_holds_priority || $item->exclude_from_local_holds_priority != $exclude_from_local_holds_priority) {
> $item->exclude_from_local_holds_priority($exclude_from_local_holds_priority)->store;
> $modified_holds_priority = 1;
> }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19889: 105715 | 105716 | 105717 | 105718 | 106435 | 106436 | 106437 | 106438 | 106439 | 106440 | 106441 | 106442 | 107180 | 107187 | 107188 | 107189 | 107190 | 107191 | 107192 | 107193 | 107194 | 107195 | 107196 | 107908 | 107909 | 107910 | 107911 | 107912 | 107913 | 107926 | 107927 | 107928 | 107929 | 107930 | 107931 | 107948 | 108213 | 108214 | 108215 | 108216 | 108217 | 108218 | 108219 | 108220 | 108593 | 108594 | 108595 | 108725 | 108726 | 108728 | 109131 | 109132 | 109285 | 109364 | 109419