Attachment 108639 Details for Bug 16112 – Bug 24288: Add wording to authorized value interface to indicate valid code length

[patch] Bug 24288: Add wording to authorized value interface to indicate valid code length

Bug-24288-Add-wording-to-authorized-value-interfac.patch (text/plain), 2.08 KB, created by Marco Abi-Ramia on 2020-08-19 14:57:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marco Abi-Ramia

Created: 2020-08-19 14:57:55 UTC

Size: 2.08 KB

patch

obsolete

>From 1e7fbf7461f3bc35e81f9fd4057c65c5b6b72453 Mon Sep 17 00:00:00 2001
>From: David Roberts <david@koha-ptfs.co.uk>
>Date: Thu, 16 Apr 2020 08:39:36 +0000
>Subject: [PATCH] Bug 24288: Add wording to authorized value interface to
> indicate valid code length
>
>Chnged NOTFORLOAN to NOT_LOAN
>
>This patch adds a warning that the authorized value field needs to be a
>single numeric character, where appropriate
>
>To test:
>
>1) Apply the patch
>2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories
>3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value"
>4) Check that this same warning appears when modifying the same
>authorised values
>5) Check that the warning doesn't appear in any other authorized value
>category.
>
>https://bugs.koha-community.org/show_bug.cgi?id=16112
>---
> .../intranet-tmpl/prog/en/modules/admin/authorised_values.tt   | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>index 17bd962d87..9bd49fa336 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>@@ -71,6 +71,9 @@
>             <label for="authorised_value">Authorized value: </label>
>             [% IF ( action_modify ) %]<input type="hidden" id="id" name="id" value="[% id | html %]" />[% END %]
>             <input type="text" id="authorised_value" name="authorised_value" value="[% authorised_value | html %]" maxlength="80" class="focus" />
>+            [% IF category == 'LOST' OR category == 'WITHDRAWN' OR category == 'NOT_LOAN' OR category == 'DAMAGED' OR category == 'RESTRICTED' %]
>+             <span class="authvalue_lengthalert">The authorized value field in the [% category %] category must be a one-digit numeric value</span>
>+            [% END %]
>         </li>
>         <li>
>             <label for="lib">Description: </label>
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 16112: 107786 | 107835 | 107865 | 107890 | 107891 | 108639 | 108640 | 108641 | 108658 | 108659 | 108661 | 108662 | 108663 | 108665 | 108776 | 108871 | 108872 | 108873