Attachment 108693 Details for Bug 26150 – Bug 26150: Remove the use of jquery.checkboxes plugin from inventory page

[patch] Bug 26150: Remove the use of jquery.checkboxes plugin from inventory page

Bug-26150-Remove-the-use-of-jquerycheckboxes-plugi.patch (text/plain), 2.36 KB, created by Brandon J on 2020-08-19 19:43:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brandon J

Created: 2020-08-19 19:43:53 UTC

Size: 2.36 KB

patch

obsolete

>From e6c01a00235edfbe61961dbcf3ccf0ba88e3d64f Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 5 Aug 2020 17:00:26 +0000
>Subject: [PATCH] Bug 26150: Remove the use of jquery.checkboxes plugin from
> inventory page
>
>This patch removes the use of the jquery.checkboxes plugin from the
>inventory page and replaces it with custom JS.
>
>To test, apply the patch and go to Tools -> Inventory.
>
> - Submit the form with some selections which will return results on the
>   following page. I filtered by library.
> - On the page showing results, test that the "Select all" and "Clear
>   all" links work correctly.
>
>Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>
>---
> .../prog/en/modules/tools/inventory.tt        | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>index 18379a1c86..2db78af6bd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>@@ -274,7 +274,6 @@
>     [% Asset.js("js/tools-menu.js") | $raw %]
>     [% INCLUDE 'datatables.inc' %]
>     [% INCLUDE 'calendar.inc' %]
>-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
>     <script type="text/javascript">
>         function checkForm() {
>             if ( $('#uploadbarcodes').val() ) {
>@@ -351,15 +350,19 @@
>                 return false;
>             });
> 
>-
>-            $(".checkall").click(function(){
>-                    $(".checkboxed").checkCheckboxes();
>-                    return false;
>+            var checkboxes = $("#inventoryt input:checkbox");
>+            $(".checkall").click(function(e){
>+                e.preventDefault();
>+                checkboxes.each(function(){
>+                    $(this).prop("checked", true);
>                 });
>-            $(".clearall").click(function(){
>-                    $(".checkboxed").unCheckCheckboxes();
>-                    return false;
>+            });
>+            $(".clearall").click(function(e){
>+                e.preventDefault();
>+                checkboxes.each(function(){
>+                    $(this).prop("checked", false);
>                 });
>+            });
>             $("#inventory_form").on("submit",function(){
>                 return checkForm();
>             });
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 26150: 107853 | 108693 | 108763