Attachment 108815 Details for Bug 26265 – Bug 26265: Add test for missing directory in Makefile.PL

[patch] Bug 26265: Add test for missing directory in Makefile.PL

Bug-26265-Add-test-for-missing-directory-in-Makefi.patch (text/plain), 1.86 KB, created by Jonathan Druart on 2020-08-21 13:10:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-08-21 13:10:38 UTC

Size: 1.86 KB

patch

obsolete

>From 2db09ce850b2fb95be1e88db9ef23401ee5d90fe Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 21 Aug 2020 15:09:44 +0200
>Subject: [PATCH] Bug 26265: Add test for missing directory in Makefile.PL
>
>---
> xt/check_makefile.t | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100755 xt/check_makefile.t
>
>diff --git a/xt/check_makefile.t b/xt/check_makefile.t
>new file mode 100755
>index 0000000000..23a8bf3b05
>--- /dev/null
>+++ b/xt/check_makefile.t
>@@ -0,0 +1,42 @@
>+#!/usr/bin/perl
>+
>+# Copyright 2020 Koha Development Team
>+#
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+use Test::More;
>+
>+use File::Spec;
>+use File::Slurp qw( read_file );
>+use Data::Dumper;
>+
>+my $curdir = File::Spec->curdir();
>+my @dirs = `find $curdir -maxdepth 1 -type d`;
>+my $makefile = read_file("$curdir/Makefile.PL");
>+my @missing;
>+for my $d ( sort @dirs ) {
>+    chomp $d;
>+    next if $d eq './Koha';
>+    next if $d eq './C4';
>+    next if $d eq './koha-tmpl';
>+    next if $d eq './etc';
>+    next if $d eq './debian';
>+    next if $makefile =~ m|'$d'|gxms;
>+    push @missing, $d;
>+}
>+
>+is( scalar @missing, 0, 'All directories must be listed in Makefile.PL' ) or diag Dumper \@missing;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26265: 108781 | 108783 | 108815 | 108816 | 108819 | 108967 | 108968 | 108969 | 108970 | 108971 | 109071