Attachment 108879 Details for Bug 25727 – Bug 25727: (follow-up) Use CSS specificity rather than !important

[patch] Bug 25727: (follow-up) Use CSS specificity rather than !important

Bug-25727-follow-up-Use-CSS-specificity-rather-tha.patch (text/plain), 2.12 KB, created by Katrin Fischer on 2020-08-21 22:09:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-08-21 22:09:28 UTC

Size: 2.12 KB

patch

obsolete

>From 44529854834ae138279e8895318bdbe554a2a857 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 17 Jun 2020 16:34:50 +0000
>Subject: [PATCH] Bug 25727: (follow-up) Use CSS specificity rather than
> !important
>
>This patch adds specificty to the CSS which controls the "invalid"
>appearance of a Select2 dropdown so that the use of "!important" can be
>avoided. The patch also puts this style into our custom select2 CSS file
>so that it is located with other Select2 style changes.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/css/select2.css           | 11 ++++-------
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss |  4 ++--
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/select2.css b/koha-tmpl/intranet-tmpl/prog/css/select2.css
>index c9550fd308..a6d22c2913 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/select2.css
>+++ b/koha-tmpl/intranet-tmpl/prog/css/select2.css
>@@ -2,11 +2,8 @@
>     background-color: initial;
> }
> 
>-.select2-container.subfield_not_filled .select2-choice {
>-    background: initial;
>-    background-color : #FFFF99;
>+.select2-container.missing .select2-choice,
>+.select2-container .select2-selection--single.subfield_not_filled,
>+.select2-container .select2-selection--single.important_subfield_not_filled {
>+    background-color: #FFFF99;
> }
>-
>-.select2-container.missing .select2-choice {
>-    background: #ffc none;
>-}
>\ No newline at end of file
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 6776999299..e339309288 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -1541,11 +1541,11 @@ input[type='text']:read-only:focus {
> }
> 
> .subfield_not_filled {
>-    background-color: #FFFF99 !important;
>+    background-color: #FFFF99;
> }
> 
> .important_subfield_not_filled {
>-    background-color : #FFFFCC !important;
>+    background-color : #FFFFCC;
> }
> 
> .content_hidden {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25727: 105822 | 105853 | 105854 | 105855 | 105975 | 105976 | 105977 | 105978 | 105979 | 105980 | 108351 | 108352 | 108353 | 108354 | 108355 | 108395 | 108400 | 108436 | 108823 | 108829 | 108830 | 108875 | 108876 | 108877 | 108878 | 108879 | 108880 | 108881 | 108882 | 109359 | 109361