Bugzilla – Attachment 108899 Details for
Bug 25534
Add ability to specifying and store a reason when cancelling a hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25534: (QA follow-up) Add sample notice
Bug-25534-QA-follow-up-Add-sample-notice.patch (text/plain), 2.54 KB, created by
Katrin Fischer
on 2020-08-22 09:57:19 UTC
(
hide
)
Description:
Bug 25534: (QA follow-up) Add sample notice
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-08-22 09:57:19 UTC
Size:
2.54 KB
patch
obsolete
>From 6217dc3071aa076a6909cbf62c944ea0bae126ae Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 20 Aug 2020 12:26:46 -0400 >Subject: [PATCH] Bug 25534: (QA follow-up) Add sample notice > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > installer/data/mysql/atomicupdate/cancellation_reason.perl | 4 ++++ > installer/data/mysql/en/mandatory/sample_notices.yml | 13 +++++++++++++ > 2 files changed, 17 insertions(+) > >diff --git a/installer/data/mysql/atomicupdate/cancellation_reason.perl b/installer/data/mysql/atomicupdate/cancellation_reason.perl >index cd73a1803b..f1c1257de9 100644 >--- a/installer/data/mysql/atomicupdate/cancellation_reason.perl >+++ b/installer/data/mysql/atomicupdate/cancellation_reason.perl >@@ -1,5 +1,9 @@ > $DBversion = 'XXX'; # will be replaced by the RM > if ( CheckVersion( $DBversion ) ) { >+ $dbh->do(q{ >+INSERT INTO `letter` VALUES ('reserves','HOLD_CANCELLATION','','Hold Cancellation',0,'Your hold was canceled.','[%- USE AuthorisedValues -%]\r\nDear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nYour hold for [% biblio.title %] was canceled for the following reason: [% AuthorisedValues.GetByCode( \'HOLD_CANCELLATION\', hold.cancellation_reason ) %]','email','default'); >+ }); >+ > if ( !column_exists( 'reserves', 'cancellation_reason' ) ) { > $dbh->do(q{ > ALTER TABLE reserves ADD COLUMN `cancellation_reason` varchar(80) default NULL AFTER cancellationdate; >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index e2d4b121bf..7554abb5d3 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -1208,3 +1208,16 @@ tables: > - "[% ELSE %]" > - "The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due | $KohaDates as_due_date => 1 %]" > - "[% END %]" >+ >+ - module: reserves >+ code: HOLD_CANCELLATION >+ branchcode: "" >+ name: "Notification of hold cancellation" >+ is_html: 0 >+ title: "Your hold was canceled." >+ message_transport_type: email >+ lang: default >+ content: >+ - "[%- USE AuthorisedValues -%]" >+ - "Dear [% borrower.firstname %] [% borrower.surname %]," >+ - "Your hold for [% biblio.title %] was canceled for the following reason: [% AuthorisedValues.GetByCode( 'HOLD_CANCELLATION', hold.cancellation_reason ) %]" >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25534
:
105034
|
105035
|
105036
|
105077
|
105078
|
105079
|
105105
|
105106
|
105108
|
105109
|
105110
|
105111
|
105112
|
105113
|
105114
|
105115
|
105116
|
105117
|
105118
|
105119
|
105120
|
105121
|
105122
|
105147
|
105148
|
105149
|
105150
|
105151
|
108476
|
108477
|
108478
|
108479
|
108480
|
108481
|
108746
|
108747
|
108748
|
108749
|
108750
|
108751
|
108752
|
108753
|
108754
|
108755
|
108756
|
108757
|
108805
|
108806
|
108891
|
108892
|
108893
|
108894
|
108895
|
108896
|
108897
|
108898
| 108899 |
108900
|
108901
|
108902
|
108903
|
108904
|
108977
|
108985
|
108986
|
108990
|
114026
|
114027
|
114788