Bugzilla – Attachment 108947 Details for
Bug 25791
SCO print dialog pops up twice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25791: Remove win.print()
Bug-25791-Remove-winprint.patch (text/plain), 1.73 KB, created by
Katrin Fischer
on 2020-08-23 01:00:50 UTC
(
hide
)
Description:
Bug 25791: Remove win.print()
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-08-23 01:00:50 UTC
Size:
1.73 KB
patch
obsolete
>From 37dca96afd29cb9e6ab3308fc919b5eda8a23ff1 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 15 Jul 2020 22:28:07 +0000 >Subject: [PATCH] Bug 25791: Remove win.print() > >Test plan: >1) Turn on system preference SelfCheckReceiptPrompt >2) Check out item via /cgi-bin/koha/sco/sco-main.pl >3) Click "Finish" >4) Click 'Print receipt and end session' >5) Notice two print dialog boxes right on top of each other >6) Apply patch >7) Repeat steps 1 - 4 >8) Should only get a single print dialog. >9) Test in FF/Chrome and make sure behavior is consistent > >Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index c428886a4d..8a05dd4d0b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -481,7 +481,6 @@ > confirmModal("", _("Would you like to print a receipt?"), _("Print receipt and end session"), _("End session"), function(result) { > if ( result && (Date.now() - confirmStart) < [% SelfCheckTimeout | html %] ) { > var win = window.open("/cgi-bin/koha/sco/printslip.pl?borrowernumber=[% borrowernumber | html %]&print=qslip"); >- win.print(); > location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout'; > } else { > location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout'; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25791
:
106941
|
107860
| 108947