Attachment 108953 Details for Bug 25033 – Bug 25033: (follow-up) Don't delete branchcode key from suggestion_ref

[patch] Bug 25033: (follow-up) Don't delete branchcode key from suggestion_ref

Bug-25033-follow-up-Dont-delete-branchcode-key-fro.patch (text/plain), 1.14 KB, created by Katrin Fischer on 2020-08-23 10:46:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-08-23 10:46:01 UTC

Size: 1.14 KB

patch

obsolete

>From d72530c9b28dbe30c7770d2712d85eb6fc3e75e2 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 5 Aug 2020 11:50:39 +0000
>Subject: [PATCH] Bug 25033: (follow-up) Don't delete branchcode key from
> suggestion_ref
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> suggestion/suggestion.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl
>index 560a524c77..48527ae363 100755
>--- a/suggestion/suggestion.pl
>+++ b/suggestion/suggestion.pl
>@@ -219,7 +219,7 @@ if ( $op =~ /save/i ) {
>             }
>             # empty fields, to avoid filter in "SearchSuggestion"
>         }
>-        map{delete $$suggestion_ref{$_}} keys %$suggestion_ref;
>+        map{delete $$suggestion_ref{$_} unless $_ eq 'branchcode' } keys %$suggestion_ref;
>         $op = 'else';
> 
>         if( $redirect eq 'purchase_suggestions' ) {
>@@ -324,7 +324,7 @@ elsif ( $op eq 'show' ) {
> }
> if ($op=~/else/) {
>     $op='else';
>-    
>+
>     $displayby||="STATUS";
>     # distinct values of display by
>     my $criteria_list=GetDistinctValues("suggestions.".$displayby);
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25033: 102225 | 102226 | 102227 | 102228 | 102282 | 102283 | 102284 | 102285 | 102299 | 102300 | 102301 | 102302 | 102922 | 104091 | 104092 | 104093 | 104160 | 104161 | 104162 | 104357 | 104940 | 107831 | 108948 | 108949 | 108950 | 108951 | 108952 | 108953 | 108954 | 108984