Attachment 108971 Details for Bug 26265 – Bug 26265: (QA follow-up) Remove g option from regex, add few dirs

[patch] Bug 26265: (QA follow-up) Remove g option from regex, add few dirs

Bug-26265-QA-follow-up-Remove-g-option-from-regex-.patch (text/plain), 1.10 KB, created by Marcel de Rooy on 2020-08-24 08:38:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-08-24 08:38:52 UTC

Size: 1.10 KB

patch

obsolete

>From 782749b902cdad9e6495ad3fc203db7151c95919 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 24 Aug 2020 08:03:48 +0000
>Subject: [PATCH] Bug 26265: (QA follow-up) Remove g option from regex, add few
> dirs
>Content-Type: text/plain; charset=utf-8
>
>Adding .git. Using a regex.
>If we make it a bit smarter, we do not need most dirs listed.
>
>Test plan:
>Run the test again
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> xt/check_makefile.t | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/xt/check_makefile.t b/xt/check_makefile.t
>index 23a8bf3b05..458f19520c 100755
>--- a/xt/check_makefile.t
>+++ b/xt/check_makefile.t
>@@ -30,12 +30,8 @@ my $makefile = read_file("$curdir/Makefile.PL");
> my @missing;
> for my $d ( sort @dirs ) {
>     chomp $d;
>-    next if $d eq './Koha';
>-    next if $d eq './C4';
>-    next if $d eq './koha-tmpl';
>-    next if $d eq './etc';
>-    next if $d eq './debian';
>-    next if $makefile =~ m|'$d'|gxms;
>+    next if $d =~ /\.\/(debian|\.git)$/;
>+    next if $makefile =~ m{'$d('|\/)}xms;
>     push @missing, $d;
> }
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26265: 108781 | 108783 | 108815 | 108816 | 108819 | 108967 | 108968 | 108969 | 108970 | 108971 | 109071