Attachment 108984 Details for Bug 25033 – Bug 25033: (follow-up) Don't limit suggestions to branches if displaying by branch

[patch] Bug 25033: (follow-up) Don't limit suggestions to branches if displaying by branch

Bug-25033-follow-up-Dont-limit-suggestions-to-bran.patch (text/plain), 1.17 KB, created by Nick Clemens (kidclamp) on 2020-08-24 12:31:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-08-24 12:31:23 UTC

Size: 1.17 KB

patch

obsolete

>From e2716a23971e952d067bab664a8924c1b09c8995 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 24 Aug 2020 12:26:04 +0000
>Subject: [PATCH] Bug 25033: (follow-up) Don't limit suggestions to branches if
> displaying by branch
>
>In the case of organizing by branches we should not filter by branch
>---
> suggestion/suggestion.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl
>index 48527ae363..bd4c1a0696 100755
>--- a/suggestion/suggestion.pl
>+++ b/suggestion/suggestion.pl
>@@ -355,7 +355,7 @@ if ($op=~/else/) {
>         }
>         my $definedvalue = defined $$suggestion_ref{$displayby} && $$suggestion_ref{$displayby} ne "";
> 
>-        next if ( $definedvalue && $$suggestion_ref{$displayby} ne $criteriumvalue ) and ($displayby ne 'branchcode' or $branchfilter ne '__ANY__' );
>+        next if ( $definedvalue && $$suggestion_ref{$displayby} ne $criteriumvalue ) and ($displayby ne 'branchcode' && $branchfilter ne '__ANY__' );
>         $$suggestion_ref{$displayby} = $criteriumvalue;
> 
>         my $suggestions = &SearchSuggestion({ %$suggestion_ref, archived => $filter_archived });
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25033: 102225 | 102226 | 102227 | 102228 | 102282 | 102283 | 102284 | 102285 | 102299 | 102300 | 102301 | 102302 | 102922 | 104091 | 104092 | 104093 | 104160 | 104161 | 104162 | 104357 | 104940 | 107831 | 108948 | 108949 | 108950 | 108951 | 108952 | 108953 | 108954 | 108984