Attachment 108985 Details for Bug 25534 – Bug 25534: (QA follow-up) Update Koha::Hold::cancel POD

[patch] Bug 25534: (QA follow-up) Update Koha::Hold::cancel POD

Bug-25534-QA-follow-up-Update-KohaHoldcancel-POD.patch (text/plain), 1.10 KB, created by Kyle M Hall (khall) on 2020-08-24 13:14:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-08-24 13:14:39 UTC

Size: 1.10 KB

patch

obsolete

>From c708de555fe87f72413382fbbb8f8df26b3e483e Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 24 Aug 2020 09:13:00 -0400
>Subject: [PATCH] Bug 25534: (QA follow-up) Update Koha::Hold::cancel POD
>
>---
> Koha/Hold.pm | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Hold.pm b/Koha/Hold.pm
>index 67e8d53757..360b43e7b5 100644
>--- a/Koha/Hold.pm
>+++ b/Koha/Hold.pm
>@@ -351,12 +351,18 @@ sub is_suspended {
> 
> =head3 cancel
> 
>-my $cancel_hold = $hold->cancel();
>+my $cancel_hold = $hold->cancel(
>+    {
>+        [ charge_cancel_fee => 1||0, ]
>+        [ cancellation_reason => $cancellation_reason, ]
>+    }
>+);
> 
> Cancel a hold:
> - The hold will be moved to the old_reserves table with a priority=0
> - The priority of other holds will be updated
> - The patron will be charge (see ExpireReservesMaxPickUpDelayCharge) if the charge_cancel_fee parameter is set
>+- The canceled hold will have the cancellation reason added to old_reserves.cancellation_reason if one is passed in
> - a CANCEL HOLDS log will be done if the pref HoldsLog is on
> 
> =cut
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 25534: 105034 | 105035 | 105036 | 105077 | 105078 | 105079 | 105105 | 105106 | 105108 | 105109 | 105110 | 105111 | 105112 | 105113 | 105114 | 105115 | 105116 | 105117 | 105118 | 105119 | 105120 | 105121 | 105122 | 105147 | 105148 | 105149 | 105150 | 105151 | 108476 | 108477 | 108478 | 108479 | 108480 | 108481 | 108746 | 108747 | 108748 | 108749 | 108750 | 108751 | 108752 | 108753 | 108754 | 108755 | 108756 | 108757 | 108805 | 108806 | 108891 | 108892 | 108893 | 108894 | 108895 | 108896 | 108897 | 108898 | 108899 | 108900 | 108901 | 108902 | 108903 | 108904 | 108977 | 108985 | 108986 | 108990 | 114026 | 114027 | 114788