Bugzilla – Attachment 10899 Details for
Bug 2060
Ability to import Authorities from Staff Client
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8063 - Followup - Bug fix
Bug-8063---Followup---Bug-fix.patch (text/plain), 2.46 KB, created by
Elliott Davis
on 2012-07-17 14:31:07 UTC
(
hide
)
Description:
Bug 8063 - Followup - Bug fix
Filename:
MIME Type:
Creator:
Elliott Davis
Created:
2012-07-17 14:31:07 UTC
Size:
2.46 KB
patch
obsolete
>From 1cafc11a4028d0334765f595672b7ef044bdd9f8 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 6 Jun 2012 09:41:02 -0400 >Subject: [PATCH] Bug 8063 - Followup - Bug fix > >$OUTPUT being used but not being declared. > >When trying to run this script I gat a nasty: >15:42 ~/koha.dev/koha-community (new/bug_8063 $%)$ ./misc/cronjobs/gather_print_notices.pl >Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 81. >Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 95. >Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 102. >Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 106. >Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 120. >Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 127. >Execution of ./misc/cronjobs/gather_print_notices.pl aborted due to compilation errors. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Before the patch: >$perl -wc ./misc/cronjobs/gather_print_notices.pl >Global symbol "$OUTPUT" requires explicit package name at >[...]./misc/cronjobs/gather_print_notices.pl line 81. >./misc/cronjobs/gather_print_notices.pl had compilation errors. > >With this patch: >$perl -wc ./misc/cronjobs/gather_print_notices.pl >./misc/cronjobs/gather_print_notices.pl syntax OK > >Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> > >http://bugs.koha-community.org/show_bug.cgi?id=2060 >--- > misc/cronjobs/gather_print_notices.pl | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/misc/cronjobs/gather_print_notices.pl b/misc/cronjobs/gather_print_notices.pl >index ba3050e..286b035 100755 >--- a/misc/cronjobs/gather_print_notices.pl >+++ b/misc/cronjobs/gather_print_notices.pl >@@ -69,6 +69,8 @@ my $today = C4::Dates->new(); > my @all_messages = @{ GetPrintMessages() }; > exit unless (@all_messages); > >+my $OUTPUT; >+ > if ($split) { > my %messages_by_branch; > foreach my $message (@all_messages) { >@@ -77,7 +79,6 @@ if ($split) { > > foreach my $branchcode ( keys %messages_by_branch ) { > my @messages = @{ $messages_by_branch{$branchcode} }; >- > open $OUTPUT, '>', > File::Spec->catdir( $output_directory, > "holdnotices-" . $today->output('iso') . "-$branchcode.html" ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2060
:
10893
|
10894
|
10895
|
10899
|
10900
|
10901
|
10902
|
11258
|
11259
|
11260
|
12150
|
12151
|
12152
|
12195
|
12198
|
12213
|
12215
|
12218
|
12346
|
12347
|
12348