Attachment 109021 Details for Bug 23166 – Bug 23166: Remove baskets_deletedorders code

[patch] Bug 23166: Remove baskets_deletedorders code

Bug-23166-Remove-basketsdeletedorders-code.patch (text/plain), 5.86 KB, created by Joonas Kylmälä on 2020-08-24 15:54:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2020-08-24 15:54:48 UTC

Size: 5.86 KB

patch

obsolete

>From 412b39250745b3ed95964b3c096cf369f33c5239 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 19 Jun 2019 21:11:20 -0500
>Subject: [PATCH] Bug 23166: Remove baskets_deletedorders code
>
>This is never used.
>---
> catalogue/ISBDdetail.pl        | 4 ----
> catalogue/MARCdetail.pl        | 4 ----
> catalogue/detail.pl            | 6 ------
> catalogue/imageviewer.pl       | 4 ----
> catalogue/labeledMARCdetail.pl | 4 ----
> catalogue/moredetail.pl        | 4 ----
> 6 files changed, 26 deletions(-)
>
>diff --git a/catalogue/ISBDdetail.pl b/catalogue/ISBDdetail.pl
>index 6999c0455f..8e1ea52caf 100755
>--- a/catalogue/ISBDdetail.pl
>+++ b/catalogue/ISBDdetail.pl
>@@ -154,15 +154,11 @@ $template->param (
> my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
> my @deletedorders_using_biblio;
> my @orders_using_biblio;
>-my @baskets_deletedorders;
> 
> foreach my $myorder (@allorders_using_biblio) {
>     my $basket = $myorder->{'basketno'};
>     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
>         push @deletedorders_using_biblio, $myorder;
>-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
>-            push @baskets_deletedorders,$myorder->{'basketno'};
>-        }
>     }
>     else {
>         push @orders_using_biblio, $myorder;
>diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl
>index bd6341b590..eb9553331a 100755
>--- a/catalogue/MARCdetail.pl
>+++ b/catalogue/MARCdetail.pl
>@@ -347,15 +347,11 @@ $template->param (
> my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
> my @deletedorders_using_biblio;
> my @orders_using_biblio;
>-my @baskets_deletedorders;
> 
> foreach my $myorder (@allorders_using_biblio) {
>     my $basket = $myorder->{'basketno'};
>     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
>         push @deletedorders_using_biblio, $myorder;
>-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
>-            push @baskets_deletedorders,$myorder->{'basketno'};
>-        }
>     }
>     else {
>         push @orders_using_biblio, $myorder;
>diff --git a/catalogue/detail.pl b/catalogue/detail.pl
>index 5c7a1a6dfb..4ffe75c0a3 100755
>--- a/catalogue/detail.pl
>+++ b/catalogue/detail.pl
>@@ -556,15 +556,11 @@ if ($StaffDetailItemSelection) {
> my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
> my @deletedorders_using_biblio;
> my @orders_using_biblio;
>-my @baskets_deletedorders;
> 
> foreach my $myorder (@allorders_using_biblio) {
>     my $basket = $myorder->{'basketno'};
>     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
>         push @deletedorders_using_biblio, $myorder;
>-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
>-            push @baskets_deletedorders,$myorder->{'basketno'};
>-        }
>     }
>     else {
>         push @orders_using_biblio, $myorder;
>@@ -579,6 +575,4 @@ $template->param (countorders => $count_orders_using_biblio);
> my $count_deletedorders_using_biblio = scalar @deletedorders_using_biblio ;
> $template->param (countdeletedorders => $count_deletedorders_using_biblio);
> 
>-$template->param (basketsdeletedorders => \@baskets_deletedorders);
>-
> output_html_with_http_headers $query, $cookie, $template->output;
>diff --git a/catalogue/imageviewer.pl b/catalogue/imageviewer.pl
>index 21151d6263..9efba1754a 100755
>--- a/catalogue/imageviewer.pl
>+++ b/catalogue/imageviewer.pl
>@@ -90,15 +90,11 @@ $template->{VARS}->{'biblio'} = $biblio;
> my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
> my @deletedorders_using_biblio;
> my @orders_using_biblio;
>-my @baskets_deletedorders;
> 
> foreach my $myorder (@allorders_using_biblio) {
>     my $basket = $myorder->{'basketno'};
>     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
>         push @deletedorders_using_biblio, $myorder;
>-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
>-            push @baskets_deletedorders,$myorder->{'basketno'};
>-        }
>     }
>     else {
>         push @orders_using_biblio, $myorder;
>diff --git a/catalogue/labeledMARCdetail.pl b/catalogue/labeledMARCdetail.pl
>index ead7b9aeed..8799a7f805 100755
>--- a/catalogue/labeledMARCdetail.pl
>+++ b/catalogue/labeledMARCdetail.pl
>@@ -136,15 +136,11 @@ $template->param (
> my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
> my @deletedorders_using_biblio;
> my @orders_using_biblio;
>-my @baskets_deletedorders;
> 
> foreach my $myorder (@allorders_using_biblio) {
>     my $basket = $myorder->{'basketno'};
>     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
>         push @deletedorders_using_biblio, $myorder;
>-        unless (grep { $_ eq $basket } @baskets_deletedorders){
>-            push @baskets_deletedorders,$myorder->{'basketno'};
>-        }
>     }
>     else {
>         push @orders_using_biblio, $myorder;
>diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl
>index 13176493fe..ea18505b45 100755
>--- a/catalogue/moredetail.pl
>+++ b/catalogue/moredetail.pl
>@@ -270,15 +270,11 @@ $template->{'VARS'}->{'searchid'} = $query->param('searchid');
> my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
> my @deletedorders_using_biblio;
> my @orders_using_biblio;
>-my @baskets_deletedorders;
> 
> foreach my $myorder (@allorders_using_biblio) {
>     my $basket = $myorder->{'basketno'};
>     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
>         push @deletedorders_using_biblio, $myorder;
>-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
>-            push @baskets_deletedorders,$myorder->{'basketno'};
>-        }
>     }
>     else {
>         push @orders_using_biblio, $myorder;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23166: 90824 | 90825 | 90826 | 90827 | 90828 | 104365 | 104366 | 104367 | 104368 | 104369 | 104370 | 108991 | 108992 | 108993 | 108994 | 108995 | 108996 | 108997 | 108998 | 108999 | 109000 | 109001 | 109002 | 109019 | 109020 | 109021 | 109022 | 109023 | 109024 | 109025 | 109026 | 109037 | 109038 | 109039 | 109040 | 109041 | 109042 | 109043 | 109044 | 109045 | 109046 | 109047 | 109048 | 109049 | 109050 | 109058 | 109059