Attachment 109027 Details for Bug 26289 – Bug 26289: Add missing variable definition to templates

[patch] Bug 26289: Add missing variable definition to templates

Bug-26289-Add-missing-variable-definition-to-templ.patch (text/plain), 2.74 KB, created by Owen Leonard on 2020-08-24 16:53:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-08-24 16:53:51 UTC

Size: 2.74 KB

patch

obsolete

>From 1dbef217464ddc85deeb11cebb235c102e1eee8d Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 24 Aug 2020 16:32:34 +0000
>Subject: [PATCH] Bug 26289: Add missing variable definition to templates
>
>This patch adds definition of the missing "searchid" variable to three
>bibliographic detail pages. The variable is required by several
>JavaScript functions.
>
>To test, apply the patch and locate or create a record with no items.
>Open the labeled MARC view and choose Edit -> Delete record. Confirm the
>deletion. The deletion should complete correctly.
>
>Perform the same test with the ISBD view and the MARC view.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt        | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt        | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt | 1 +
> 3 files changed, 3 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
>index 1e022b1b1d..bbe4d380f9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
>@@ -60,6 +60,7 @@
>     [% Asset.js("js/browser.js") | $raw %]
>     <script>
>         var browser = KOHA.browser('[% searchid | html %]', parseInt('[% biblionumber | html %]', 10));
>+        var searchid = '[% searchid | html %]';
>         browser.show();
>     </script>
> [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>index 0816c6379c..b2f6059609 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>@@ -190,6 +190,7 @@
>     [% Asset.js("js/browser.js") | $raw %]
>     <script>
>         var browser = KOHA.browser('[% searchid | html %]', parseInt('[% biblionumber | html %]', 10));
>+        var searchid = '[% searchid | html %]';
>         browser.show();
> 
>          $(document).ready(function() {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
>index 01bd490a73..8790be3040 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
>@@ -84,6 +84,7 @@
>     <script>
>     //<![CDATA[
>         var browser = KOHA.browser('[% searchid | html %]', parseInt('[% biblionumber | html %]', 10));
>+        var searchid = '[% searchid | html %]';
>         browser.show();
>         $(document).ready(function() {
>             $("#Frameworks").on("change",function(){
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26289: 109027 | 109130 | 109187 | 109190