Bugzilla – Attachment 109058 Details for
Bug 23166
Simplify code related to orders in catalogue/*detail.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23166: Early return if no set
Bug-23166-Early-return-if-no-set.patch (text/plain), 863 bytes, created by
Jonathan Druart
on 2020-08-25 09:44:05 UTC
(
hide
)
Description:
Bug 23166: Early return if no set
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-08-25 09:44:05 UTC
Size:
863 bytes
patch
obsolete
>From 507a60abf6222c1c266bca54b7934407f9016ea4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 25 Aug 2020 11:38:32 +0200 >Subject: [PATCH] Bug 23166: Early return if no set > >It prevents valid_template check to raise >Can't call method "filter_by_current" without a package or object reference at /kohadevbox/koha/Koha/Template/Plugin/Context.pm line 49. >--- > Koha/Template/Plugin/Context.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/Koha/Template/Plugin/Context.pm b/Koha/Template/Plugin/Context.pm >index 3e5be2b3da..cccb346963 100644 >--- a/Koha/Template/Plugin/Context.pm >+++ b/Koha/Template/Plugin/Context.pm >@@ -46,6 +46,7 @@ Return object set in scalar context > > sub Scalar { > my ( $self, $set, $method ) = @_; >+ return unless $set; > $set = $set->$method; > return $set; > } >-- >2.20.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=109058">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23166
:
90824
|
90825
|
90826
|
90827
|
90828
|
104365
|
104366
|
104367
|
104368
|
104369
|
104370
|
108991
|
108992
|
108993
|
108994
|
108995
|
108996
|
108997
|
108998
|
108999
|
109000
|
109001
|
109002
|
109019
|
109020
|
109021
|
109022
|
109023
|
109024
|
109025
|
109026
|
109037
|
109038
|
109039
|
109040
|
109041
|
109042
|
109043
|
109044
|
109045
|
109046
|
109047
|
109048
|
109049
|
109050
|
109058
|
109059