Attachment 109059 Details for Bug 23166 – Bug 23166: Early return if no set

[patch] Bug 23166: Early return if no set

Bug-23166-Early-return-if-no-set.patch (text/plain), 1015 bytes, created by Joonas Kylmälä on 2020-08-25 09:47:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2020-08-25 09:47:09 UTC

Size: 1015 bytes

patch

obsolete

>From f3cd7c48d7e9f0a0d7232d291a4b6600e94fd05e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 25 Aug 2020 11:38:32 +0200
>Subject: [PATCH] Bug 23166: Early return if no set
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>It prevents valid_template check to raise
>Can't call method "filter_by_current" without a package or object reference at /kohadevbox/koha/Koha/Template/Plugin/Context.pm line 49.
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@helsinki.fi>
>---
> Koha/Template/Plugin/Context.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/Template/Plugin/Context.pm b/Koha/Template/Plugin/Context.pm
>index 3e5be2b3da..cccb346963 100644
>--- a/Koha/Template/Plugin/Context.pm
>+++ b/Koha/Template/Plugin/Context.pm
>@@ -46,6 +46,7 @@ Return object set in scalar context
> 
> sub Scalar {
>     my ( $self, $set, $method ) = @_;
>+    return unless $set;
>     $set = $set->$method;
>     return $set;
> }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23166: 90824 | 90825 | 90826 | 90827 | 90828 | 104365 | 104366 | 104367 | 104368 | 104369 | 104370 | 108991 | 108992 | 108993 | 108994 | 108995 | 108996 | 108997 | 108998 | 108999 | 109000 | 109001 | 109002 | 109019 | 109020 | 109021 | 109022 | 109023 | 109024 | 109025 | 109026 | 109037 | 109038 | 109039 | 109040 | 109041 | 109042 | 109043 | 109044 | 109045 | 109046 | 109047 | 109048 | 109049 | 109050 | 109058 | 109059